1788907 - Support multiple domains per CookieBannerRule

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, task, P2)

Description

[Emma Zühlcke [:emz]]

For sites that are not covered by global rules (to be implemented), but still have multiple domains showing the same banner we currently have to create multiple duplicate rules, one per domain.

We can update the format of CookieBannerRule to accept an array of domains.

On import nsCookieBannerService#insertRule can simply set the same rule object for multiple domains in the hash map.

Example use cases (different domains, same banner):

• StackExchange sites (StackOverflow etc)
• Google search (country tlds)

Comment 1

[Emma Zühlcke [:emz]]

Attachment: Bug 1788907 - Add support for multiple domains per nsICookieBannerRule. r=timhuang!

Comment 2

[Emma Zühlcke [:emz]]

Attachment: Bug 1788907 - Avoid static_cast for conversion from nsICookie to net::Cookie. r=timhuang!

Depends on D163356

Comment 3

[Emma Zühlcke [:emz]]

Attachment: Bug 1788907 - Backwards compatibility for single-domain cookie banner rules. r=timhuang!

Depends on D163357

Comment 4

[Emma Zühlcke [:emz]]

Attachment: Bug 1788907 - Update tests for nsICookieBannerRule domains field. r=timhuang!

Depends on D163358

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/8d25eaf53c7d
Add support for multiple domains per nsICookieBannerRule. r=timhuang
https://hg.mozilla.org/mozilla-central/rev/900cb877982a
Avoid static_cast for conversion from nsICookie to net::Cookie. r=timhuang
https://hg.mozilla.org/mozilla-central/rev/022ad7affbc9
Backwards compatibility for single-domain cookie banner rules. r=timhuang
https://hg.mozilla.org/mozilla-central/rev/21cb6588a290
Update tests for nsICookieBannerRule domains field. r=timhuang

Comment 6

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/8d25eaf53c7d
https://hg.mozilla.org/mozilla-central/rev/900cb877982a
https://hg.mozilla.org/mozilla-central/rev/022ad7affbc9
https://hg.mozilla.org/mozilla-central/rev/21cb6588a290