Closed
Bug 1789034
Opened 2 years ago
Closed 2 years ago
Random minor clean up in layout
Categories
(Core :: Layout, task)
Core
Layout
Tracking
()
RESOLVED
FIXED
106 Branch
| Tracking | Status | |
|---|---|---|
| firefox106 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
Details
Attachments
(3 files)
Spot minor clean up opportunities while diving into layout code.
|
Assignee | |
Comment 1•2 years ago
|
||
All the callers are passing values to border and padding, so no need to provide
empty default values.
|
|
Assignee | |
Comment 2•2 years ago
|
||
It has been used in rest of the method via its alias eStretchPreservingRatio
defined in a few lines below.
Depends on D156354
|
|
Assignee | |
Comment 3•2 years ago
|
||
This method already works in logical coordinates. We should name it correctly.
Depends on D156355
Pushed by aethanyc@gmail.com: https://hg.mozilla.org/integration/autoland/rev/a37d1942d39e Remove default values for SizeComputationInput::InitOffsets(). r=emilio https://hg.mozilla.org/integration/autoland/rev/0318f6647c33 Delete obsolete comment for Stretch::StretchPreservingRatio. r=emilio https://hg.mozilla.org/integration/autoland/rev/be94662b0a4c Rename ShrinkWidthToFit to ShrinkISizeToFit. r=emilio
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a37d1942d39e
https://hg.mozilla.org/mozilla-central/rev/0318f6647c33
https://hg.mozilla.org/mozilla-central/rev/be94662b0a4c
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox106:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•