1789103 - Certain videos can't loop

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[tgn-ff]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:106.0) Gecko/20100101 Firefox/106.0

Steps to reproduce:

1. Open this link: https://imgur.com/gallery/zGG5Ayo.
2. Let the video reach the end.

Actual results:

When the video ends, it doesn't loop. This doesn't affect every video.

Expected results:

Mozregression result:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ea4e821c2084b1c9e9298534c201261f8bdcba2d&tochange=c09aaf7f51461fe8a0cd91fac46e9917cfa3d767

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:padenot, since you are the author of the regressor, bug 1780150, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 2

[Paul Adenot (:padenot)]

We need to back bug 1780150 out, and do another fix probably.

Comment 3

[Paul Adenot (:padenot)]

Attachment: Bug 1789103 - Backout 1780150 for breaking playback of video that have an audio track shorter than a video track. r?alwu

Comment 4

[Paul Adenot (:padenot)]

Attachment: Bug 1789103 - When muted and dropping audio, resolve the ended promise a bit early to mimic the audio stream having finished consuming but not draining. r?alwu

Depends on D156470

Comment 5

[Andreea Pavel [:apavel]]

Hi Paul, can the backout patch get landed to reduce failures in bug 1787040?

Comment 6

[Paul Adenot (:padenot)]

Yes, I'm landing the back-out right now, and will follow up.

Comment 7

[Atila Butkovits]

Backed out for causing build bustages.

Backout link: https://hg.mozilla.org/integration/autoland/rev/8115c8902ab5397c53fc96f74ba3f2a001001cc3

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=3b3a7e5ede5be975cefc6b5c97de952c623a4db9

Failure log: https://treeherder.mozilla.org/logviewer?job_id=390494389&repo=autoland&lineNumber=1246

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34dd0354a1df
Backout 1780150 for breaking playback of video that have an audio track shorter than a video track. r=alwu,media-playback-reviewers

Comment 9

[Andreea Pavel [:apavel]]

Pulsebot had an issue and the autoland comment was posted later, the backout is the latest action on this bug.

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Auto nag want the backout url posted because it doesn't match the backout commit message format: https://hg.mozilla.org/mozilla-central/rev/34dd0354a1df

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:jimm, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 12

[Daniel Holbert [:dholbert]]

Attachment: sample video that's affected

For reference/archival, here's the affected video from https://imgur.com/gallery/zGG5Ayo

Comment 13

[Daniel Holbert [:dholbert]]

Attachment: testcase (simplified version of imgur page)

Comment 14

[Daniel Holbert [:dholbert]]

This is still UNCONFIRMED but we can call it confirmed; I can repro with STR in comment 0 (and with my attached testcase), using the linux nightly from that day.

i.e. I see the bug if I run this command:

mozregression --launch 2022-09-03 -a https://bugzilla.mozilla.org/attachment.cgi?id=9298669

...though current beta and Nightly (i.e. builds after comment 8) are unaffected, so really this is FIXED-by-backout essentially.

For tracking / reality-matching purposes, we should probably:
(A) close this bug as FIXED-by-backout (given that this bug's STR/issue have been addressed, i.e. this is no longer an issue)
(B) reopen bug 1780150 (given that its fix is no longer in the tree).

Paul, does that sound OK / do you want to do that?

Comment 15

[Paul Adenot (:padenot)]

Yes, doing that now. Thanks for the test-case!