1789150 - Keyboard shortcuts missing most of shortcuts for Style Editor

Status: RESOLVED FIXED

(DevTools :: Documentation, defect, P3)

Description

[fireattack [:fireattack]]

Steps to reproduce:

https://firefox-source-docs.mozilla.org/devtools-user/keyboard_shortcuts/index.html#style-editor

Actual results:

This list is very incomplete.

For example, it's missing Ctrl+G (search next), Ctrl+Shift+F (replace), potentially more.

Expected results:

Keep in mind these shortcuts are not necessarily the same as other components so you can't even relying on other chapter.

Ctrl+G is indeed the same as Debugger, but Ctrl+Shift+F is not, for example.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:Sylvestre, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Nicolas, I'll update the docs, do you think this is the complete list?

• Ctrl+G - Cmd+G => Find next
• Shift+Ctrl+G / Shift+Cmd+G => Find previous
• Shift+Ctrl+F / Cmd+Option+F => Replace
• Ctrl+P / Cmd+P => Focus the filter input

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

I think you're only missing Ctrl+S / Cmd+S to save file to disk

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: Bug 1789150 - Keyboard shortcuts missing most of shortcuts for Style Editor

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6494b66a6e46
Keyboard shortcuts missing most of shortcuts for Style Editor r=nchevobbe

Comment 6

[fireattack [:fireattack]]

Thanks for working on it.

Just a small question: why the Component of this bug isn't "Firefox Source Docs: Content"? This is what "Report an issue" button on that exact page told me to do: https://bugzilla.mozilla.org/enter_bug.cgi?product=Developer+Infrastructure&component=Firefox+Source+Docs%3A+Content&short_desc=Documentation+issue+on+devtools-user/keyboard_shortcuts/index&comment=URL+=+https://firefox-source-docs.mozilla.org/devtools-user/keyboard_shortcuts/index.html&bug_file_loc=https://firefox-source-docs.mozilla.org/devtools-user/keyboard_shortcuts/index.html

Is this also a bug itself?

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/6494b66a6e46

Comment 8

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to fireattack from comment #6)

Just a small question: why the Component of this bug isn't "Firefox Source Docs: Content"? This is what "Report an issue" button on that exact page told me to do: https://bugzilla.mozilla.org/enter_bug.cgi?product=Developer+Infrastructure&component=Firefox+Source+Docs%3A+Content&short_desc=Documentation+issue+on+devtools-user/keyboard_shortcuts/index&comment=URL+=+https://firefox-source-docs.mozilla.org/devtools-user/keyboard_shortcuts/index.html&bug_file_loc=https://firefox-source-docs.mozilla.org/devtools-user/keyboard_shortcuts/index.html

"Firefox Source Docs: Content" is general component covering the entire docs and it's ok to file documentation bugs there. But, many teams are responsible for building and maintaining the docs so, consequent triage is moving (documentation related bugs) to components that belong to the right team (to make sure that the right team knows about the bug).

Comment 9

[Alexandru Ionescu (needinfo me) [:alexandrui]]

(In reply to Pulsebot from comment #5)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6494b66a6e46
Keyboard shortcuts missing most of shortcuts for Style Editor r=nchevobbe

== Change summary for alert #35511 (as of Mon, 26 Sep 2022 03:56:19 GMT) ==

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
4%	twitter fcp	windows10-64-shippable-qr	bytecode-cached fission warm webrender	95.54 -> 99.43

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=35511

Comment 10

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Alexandru, this alert doesn't seem to be related to the chage. The patch is only changing documentation.