1789218 - Dangerous Flag Constant Declaration in SelectionActionDelegate

Status: RESOLVED FIXED

(GeckoView :: General, task, P3)

Description

[Makoto Kato [:m_kato]]

This is lint warning issue by ./mach lint -l android-lint.

mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoSession.java:3427: Consider declaring this constant using 1 << 1 instead
mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoSession.java:3429: Consider declaring this constant using 1 << 2 instead

FLAG_IS_COLLAPSED, FLAG_IS_EDITABLE and FLAG_IS_PASSWORD should use shift such as 1 << 1.

Comment 1

[Makoto Kato [:m_kato]]

reset Assignee by request.

Comment 2

[Ankit Anand]

I want to work on this issue as my first contribution.

Comment 3

[Makoto Kato [:m_kato]]

(In reply to Ankit Anand from comment #2)

I want to work on this issue as my first contribution.

Welcome. Contribution document is https://firefox-source-docs.mozilla.org/mobile/android/geckoview/contributor/index.html and https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html#to-submit-a-patch. And we have a chat room in https://chat.mozilla.org/#/room/#introduction:mozilla.org for new contributor.

Also, https://bugzilla.mozilla.org/show_bug.cgi?id=1510613 was similar issue.

Comment 4

[Tal [:tlavi]]

Hey, if this gets unassigned can I have it as my first contribution? (I'm so sorry if this comes off as rude, I just see it as the only recommended first issue for Java and wanted to be in line in case it isn't fixed as I saw it was reassigned once)

Comment 5

[Makoto Kato [:m_kato]]

(In reply to Tal from comment #4)

Hey, if this gets unassigned can I have it as my first contribution? (I'm so sorry if this comes off as rude, I just see it as the only recommended first issue for Java and wanted to be in line in case it isn't fixed as I saw it was reassigned once)

Welcome. :nkitanand doesn't seem to work on this now since no action after that. See comment #3 for contribution.

Comment 6

[Ankit Anand]

(In reply to Tal from comment #4)

Hey, if this gets unassigned can I have it as my first contribution? (I'm so sorry if this comes off as rude, I just see it as the only recommended first issue for Java and wanted to be in line in case it isn't fixed as I saw it was reassigned once)

Hey Tal,

I am still working on this issue. I have put too much effort and time into it. Please let me work on it.

Comment 7

[Tal [:tlavi]]

(In reply to Ankit Anand from comment #6)

(In reply to Tal from comment #4)

Hey, if this gets unassigned can I have it as my first contribution? (I'm so sorry if this comes off as rude, I just see it as the only recommended first issue for Java and wanted to be in line in case it isn't fixed as I saw it was reassigned once)

Hey Tal,

I am still working on this issue. I have put too much effort and time into it. Please let me work on it.

Of course, I'm so sorry about that! Best of luck!

Comment 8

[Ankit Anand]

Attachment: Bug 1789218 - Dangerous Flag Constant Declaration in SelectionActionDelegate. r=m_kato,#geckoview-reviewers

Changed flag constant declaration to use shift operator rather than
simple assignment as per the coding conventions.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/78e77b699bd7
Dangerous Flag Constant Declaration in SelectionActionDelegate. r=m_kato,geckoview-reviewers

Comment 10

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/78e77b699bd7