1789285 - Incorrect call to log in Policies.jsm

Status: RESOLVED FIXED

(Firefox :: Enterprise Policies, defect)

Description

[Mark Banner (:standard8)]

Whilst working on Policies.jsm I noticed that there is a global definition for ESLint that is wrong - it defines log as a global, but that is not available. It should be using lazy.log.

This would only show up if ExpireAtSessionEnd was defined in a enterprise policy, it would likely cause the rest of the Cookie policy to not be applied.

This was caused by bug 1764761 which probably happened around the time of the module changes.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1789285 - Fix incorrect log call in Policies.jsm. r?mkaply

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1764761

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8704795182d2
Fix incorrect log call in Policies.jsm. r=mkaply

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 9293170 [details]
Bug 1789285 - Fix incorrect log call in Policies.jsm. r?mkaply

Beta/Release Uplift Approval Request

• User impact if declined: If a enterprise policy is using the now deprecated ExpireAtSessionEnd field for a cookie, then processing of cookies related policies may fail and stop.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Correction for a console logging call.
• String changes made/needed:
• Is Android affected?: No

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/8704795182d2

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9293170 [details]
Bug 1789285 - Fix incorrect log call in Policies.jsm. r?mkaply

Approved for 105.0b9.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5545c1dcd7f6