1789315 - Build failure with ENABLE_RECORD_TUPLE

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Tim Chevalier]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/103.0.0.0 Safari/537.36

Steps to reproduce:

Built bookmarks/central from https://phabricator.services.mozilla.com/rMOZILLACENTRALab10436a5d1eeaf57f7b260b8844b2e34ee557e0 with the following MOZCONFIG options:

ac_add_options --enable-optimize --enable-debug --enable-record-tuple --disable-jit --enable-warnings-as-errors --enable-js-shell --with-ccache=sccache

Actual results:

The build fails:

netwerk/sctp/datachannel
In file included from Unified_cpp_js_src16.cpp:20:
/home/tjc/gecko-fork/js/src/vm/Iteration.cpp:257:16: error: use of undeclared identifier 'JS_StringToId'
          if (!JS_StringToId(cx, key, &id)) {
               ^
/home/tjc/gecko-fork/js/src/vm/Iteration.cpp:275:18: error: use of undeclared identifier 'JS_IndexToId'; did you mean 'IndexToId'?
            if (!JS_IndexToId(cx, i, &id)) {
                 ^~~~~~~~~~~~
                 IndexToId
/home/tjc/gecko-fork/js/src/vm/JSAtom-inl.h:109:13: note: 'IndexToId' declared here
inline bool IndexToId(JSContext* cx, uint32_t index, MutableHandleId idp) {
            ^
2 errors generated.

Expected results:

I'll submit a patch to fix this (missing include), but I thought that builds with ENABLE_RECORD_TUPLE set were running on CI as per bug 1744967 -- or does it just build the JS shell and not the entire browser?

Comment 1

[Tim Chevalier]

Attachment: Bug 1789315 - Eliminate jsapi.h dependency from vm/Iteration.cpp r?anba

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:tjc, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c10dbb5e7167
Eliminate jsapi.h dependency from vm/Iteration.cpp r=anba

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/c10dbb5e7167