1789366 - Crash in [@ mozilla::ipc::PUtilityProcessParent::OtherPid]

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Gabriele Svelto [:gsvelto]]

Crash report: https://crash-stats.mozilla.org/report/index/8632ee60-070b-49e5-bf56-64a850220902

Reason: EXCEPTION_ACCESS_VIOLATION_READ

Top 10 frames of crashing thread:

0 xul.dll mozilla::ipc::PUtilityProcessParent::OtherPid const ipc/ipdl/PUtilityProcessParent.cpp:53
1 xul.dll mozilla::MozPromise<bool, nsresult, 0>::ThenValue<`lambda at /builds/worker/checkouts/gecko/ipc/glue/UtilityProcessManager.cpp:275:11', `lambda at /builds/worker/checkouts/gecko/ipc/glue/UtilityProcessManager.cpp:304:11'>::DoResolveOrRejectInternal xpcom/threads/MozPromise.h:861
2 xul.dll mozilla::MozPromise<bool, mozilla::ipc::ResponseRejectReason, 1>::ThenValueBase::ResolveOrRejectRunnable::Run xpcom/threads/MozPromise.h:487
3 xul.dll mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal xpcom/threads/TaskController.cpp:851
4 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1205
5 xul.dll mozilla::ipc::MessagePump::Run ipc/glue/MessagePump.cpp:85
6 xul.dll MessageLoop::RunHandler ipc/chromium/src/base/message_loop.cc:374
7 xul.dll MessageLoop::Run ipc/chromium/src/base/message_loop.cc:356
8 xul.dll nsBaseAppShell::Run widget/nsBaseAppShell.cpp:150
9 xul.dll nsAppShell::Run widget/windows/nsAppShell.cpp:614

It seems like we're accessing a NULL object within the lambda function, not sure where to file this, Alexandre can you find an appropriate component?

Comment 1

[:gerard-majax]

Oh, it is something I did hit on bug 1788596

Comment 2

[:gerard-majax]

I clearly was reproducing that on linux, but it seems there might be other ways to reproduce on osx and windows:

• https://treeherder.mozilla.org/logviewer?job_id=389610474&repo=try&lineNumber=11798
• https://treeherder.mozilla.org/logviewer?job_id=389610464&repo=try&lineNumber=10245

Comment 3

[Gabriele Svelto [:gsvelto]]

Is this on your radar? I see the volume is climbing

Comment 4

[:gerard-majax]

I've fixed several with https://bugzilla.mozilla.org/show_bug.cgi?id=1788596, so I hope the increase is not on nightly

Comment 5

[:gerard-majax]

https://phabricator.services.mozilla.com/D156847 and https://phabricator.services.mozilla.com/D156484 are the ones that were fixing crash with the same stack, maybe we can request uplift?

Comment 6

[Gabriele Svelto [:gsvelto]]

Yeah nevermind, this looks already fixed on nightly and the release volume isn't really high, we can let the fix ride the trains.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Since the crash volume is low (less than 15 per week), the severity is downgraded to S3. Feel free to change it back if you think the bug is still critical.

For more information, please visit auto_nag documentation.

Comment 8

[:gerard-majax]

The recent crashes failures are now all on RDD: https://crash-stats.mozilla.org/report/index/0312a7a1-0e7d-4fd4-9fb4-7ea2a0230311

Comment 9

[:gerard-majax]

Gabriele, now I cannot see any signature matching on Utility instances, are we safe and can we mark this as FIXED ?

Comment 10

[Gabriele Svelto [:gsvelto]]

Yes, we're good!