1789474 - Android Fission Crash in [@ mozilla::a11y::IDSet::ReleaseID]

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Jonathan Almeida [:jonalmeida]]

Crash stats link: https://crash-stats.mozilla.org/signature/?signature=mozilla%3A%3Aa11y%3A%3AIDSet%3A%3AReleaseID&date=%3E%3D2022-08-30T18%3A30%3A00.000Z&date=%3C2022-09-06T18%3A30%3A00.000Z&_sort=-date

Reported by a Reference Browser user here (but note that Fenix is also affected):

The crash happens when I have fission enabled, I'm using my galaxy tab s5e tablet os11 one ui 3.1 andriod in dex mode.

Comment 1

[James Teh [:Jamie]]

That's a bit concerning. It suggests we're trying to unregister an id we already unregistered... or worse, we had an uninitialised id somehow. Eitan, any ideas?

Comment 2

[Chris Peterson [:cpeterson]]

123 out of 123 crash reports on Fenix Nightly 106 apparently have Fission enabled (by the user), which is surprising. In that case, I'll set status-firefox104 and status-firefox105 = disabled.

Comment 3

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1789474 - Allow detached documents to be overwritten in accessible mapping. r?Jamie

Also assure that unregistering an accessible removes the right one and
doesn't confuse the attached document with the detached one.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The bug is linked to a topcrash signature, which matches the following criterion:

• Top 10 AArch64 and ARM crashes on nightly

:eeejay, could you consider increasing the severity of this top-crash bug?

For more information, please visit auto_nag documentation.

Comment 5

[Kevin Brosnan [Ex-Mozilla]]

This is not a topcrash that is critical. It is a pref that nightly and beta users may enable. It is not a problem in release.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The bug is linked to a topcrash signature, which matches the following criterion:

• Top 10 AArch64 and ARM crashes on nightly

:eeejay, could you consider increasing the severity of this top-crash bug?

For more information, please visit auto_nag documentation.

Comment 7

[Chris Peterson [:cpeterson]]

(In reply to Kevin Brosnan [:kbrosnan] from comment #5)

This is not a topcrash that is critical. It is a pref that nightly and beta users may enable. It is not a problem in release.

Comment 8

[Chris Peterson [:cpeterson]]

If we remove the topcrash keyword, autonag will just add it back. If we leave the topcrash keyword, autonag will complain that this "top" crash is should have a higher severity. So I'll just bump the severity from S3 to S2 to make autonag happy. Let's see if autonag complains that an S2 bug should have a higher priority.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/431649004dd4
Allow detached documents to be overwritten in accessible mapping. r=Jamie,geckoview-reviewers,owlish

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/431649004dd4

Comment 11

[Sandor Molnar[:smolnar]]

Backed out for causing android gv-junit-fis-o crashes

Backout link: https://hg.mozilla.org/integration/autoland/rev/ab68ea19b50955d3de6e50e3692cfbda22b433ad

Push with failures

Failure log #1

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df6223f933ae
Allow detached documents to be overwritten in accessible mapping. r=Jamie,geckoview-reviewers,owlish

Comment 13

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/df6223f933ae