1789713 - LLVM doesn't include xdata unwinding information for _tailMerge_xxxx symbols

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

This can cause us to fail to properly unwind crashes like those in bug 1788592.

https://github.com/llvm/llvm-project/blob/7c26641d9dcea70a75ca48d2e3a5bf6ca7a925bb/lld/COFF/DLL.cpp#L198

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:gsvelto, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Yannis Juglaret [:yannis]]

Additional information is available in duplicate bug 1801322, including a tool to look for missing unwind information in binaries which can be used to assess success in fixing this bug.

Comment 4

[Gian-Carlo Pascutto [:gcp]]

Impact: if we crash on the first attempted use of a function in a delay-loaded DLL, we will not get correct unwinding (which prevented crash reporting from working entirely until bug 1801598). We delay-load many Windows DLL's in sandboxed processes.

Comment 5

[Yannis Juglaret [:yannis]]

I filed issue 59639 on the llvm-project github about this.

Comment 6

[[:sergesanspaille]]

I proposed a patch upstream: https://reviews.llvm.org/D141691

Comment 8

[[:sergesanspaille]]

Attachment: Bug 1789713 - Backport LLVM's https://reviews.llvm.org/D141691 r=glandium!

This landed upstream, so no need to backport it to clang-trunk.json

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f2a653cbb3d
Backport LLVM's https://reviews.llvm.org/D141691 r=glandium

Comment 10

[Atila Butkovits]

Backed out for causing build bustages.

Backout link: https://hg.mozilla.org/integration/autoland/rev/b1dad9107c06df86f3107e58c27d88a50b6c53c1

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=5f2a653cbb3d46dec02881e806a6d9b47df2f29f&selectedTaskRun=DAkNk7XnRlCytH089T9Ltw.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=402986539&repo=autoland&lineNumber=197

Comment 11

[Jeff Muizelaar [:jrmuizel]]

I think this change just triggered the wrench build but that build was broken by an earlier change.

Comment 12

[Jeff Muizelaar [:jrmuizel]]

Actually, the wrench build seems to be working fine elsewhere so I guess this did actually sort of break it?

Comment 13

[[:sergesanspaille]]

Hard to tell, I'll try a rebuild and check how it goes.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91091003ce86
Backport LLVM's https://reviews.llvm.org/D141691 r=glandium

Comment 15

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/91091003ce86