1789871 - FS: Enable SortIncludes option of clang-format

Status: RESOLVED FIXED

(Core :: DOM: File, task, P3)

Description

[Jan Varga [:janv]]

This will save us some time.

Comment 1

[Jan Varga [:janv]]

Attachment: Bug 1789871 - Enable SortIncludes option of clang-format; r=#dom-storage

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc3caa9e2a6d
Enable SortIncludes option of clang-format; r=dom-storage-reviewers,jesup

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing multiple lint failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/292d43f4f4d259a83975b0a6ea2ffee2f473b5e2

Push with failures

Failure log ESlint

Failure log py black

Failure log mozlint wpt

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b96f6a965872
Enable SortIncludes option of clang-format; r=dom-storage-reviewers,jesup

Comment 5

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing wpt failures . CLOSED TREE
Backout link
Push with failures
Link to failure log 1
Link to failure log 2
Failure line 1 : TEST-UNEXPECTED-FAIL | /fs/FileSystemDirectoryHandle-removeEntry.https.any.worker.html | removeEntry() while the file has an open writable fails - promise_test: Unhandled rejection with value: object "TypeError: navigator.storage.getDirectory is not a function"
Failure line 2 : TEST-UNEXPECTED-FAIL | /fs/FileSystemDirectoryHandle-removeEntry.https.any.html | removeEntry() while the file has an open writable fails - promise_test: Unhandled rejection with value: object "TypeError: navigator.storage.getDirectory is not a function"

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/37390dc34f1e
Enable SortIncludes option of clang-format; r=dom-storage-reviewers,jesup

Comment 7

[Norisz Fay [:noriszfay]]

Backed out for causing FileSystem related wpt failures

Backout link

Push with failures

Failure log

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c5ece60a4c0d
Enable SortIncludes option of clang-format; r=dom-storage-reviewers,jesup

Comment 9

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/c5ece60a4c0d

Comment 10

[Jan Varga [:janv]]

Multiple patches were landing at once, it seems there were no problems with the patch for this bug.
Anyway, the patch stack landed successfully in the end.