1790012 - Replace NativeObject::updateSlotsForSpan with more specialized functions

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Jan de Mooij [:jandem]]

updateSlotsForSpan is very generic: it's used for both adding and removing slots. We can simplify and optimize some code in this area by using more specialized functions for the different cases.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1790012 part 1 - Optimize code for adding a single slot to an object. r?jonco!

Rename setShapeAndUpdateSlotsForNewSlot to setShapeAndAddNewSlot and use a
faster path for the case where we don't need to (re)allocate dynamic slots.
Move more of the growSlots code out of line.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1790012 part 2 - Use fast path for adding a slot in NativeObject::changeProperty. r?jonco!

The goal is to get rid of setShapeAndUpdateSlots in later patches.

Depends on D156953

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1790012 part 3 - Use fast path for removing the last slot. r?jonco!

Depends on D156954

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Bug 1790012 part 4 - Don't use updateSlotsForSpan in setShapeAndUpdateSlots. r?jonco!

Rename setShapeAndUpdateSlots to setShapeAndAddNewSlots to make it clearer
we're only adding slots.

This duplicates some code from updateSlotsForSpan, but that function will be
removed in a later patch.

Depends on D156955

Comment 5

[Jan de Mooij [:jandem]]

Attachment: Bug 1790012 part 5 - Optimize adding a new slot to a dictionary object. r?jonco!

ensureSlotsForDictionaryObject will be removed in a later patch.

Depends on D156956

Comment 6

[Jan de Mooij [:jandem]]

Attachment: Bug 1790012 part 6 - Inline ensureSlotsForDictionaryObject/updateSlotsForSpan into sole caller. r?jonco!

Depends on D156957

Comment 7

[Jan de Mooij [:jandem]]

Attachment: Bug 1790012 part 7 - Stop using mozilla::Array in PropMap code. r?jonco!

mozilla::Array has release assertions for bounds checks and they show up
in some hot code paths. This is some of the hottest code in the engine so
switch to plain C++ arrays.

Depends on D156958

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb97f5816720
part 1 - Optimize code for adding a single slot to an object. r=jonco
https://hg.mozilla.org/integration/autoland/rev/f9bb1e81d184
part 2 - Use fast path for adding a slot in NativeObject::changeProperty. r=jonco
https://hg.mozilla.org/integration/autoland/rev/198dbc501dcb
part 3 - Use fast path for removing the last slot. r=jonco
https://hg.mozilla.org/integration/autoland/rev/1f1189d91f59
part 4 - Don't use updateSlotsForSpan in setShapeAndUpdateSlots. r=jonco
https://hg.mozilla.org/integration/autoland/rev/760fc689070a
part 5 - Optimize adding a new slot to a dictionary object. r=jonco
https://hg.mozilla.org/integration/autoland/rev/c459020035cc
part 6 - Inline ensureSlotsForDictionaryObject/updateSlotsForSpan into sole caller. r=jonco
https://hg.mozilla.org/integration/autoland/rev/4f53ae8e62ee
part 7 - Stop using mozilla::Array in PropMap code. r=jonco

Comment 9

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/bb97f5816720
https://hg.mozilla.org/mozilla-central/rev/f9bb1e81d184
https://hg.mozilla.org/mozilla-central/rev/198dbc501dcb
https://hg.mozilla.org/mozilla-central/rev/1f1189d91f59
https://hg.mozilla.org/mozilla-central/rev/760fc689070a
https://hg.mozilla.org/mozilla-central/rev/c459020035cc
https://hg.mozilla.org/mozilla-central/rev/4f53ae8e62ee