1790115 - Extension sidebar themed background missing in private browsing windows [web accessible resources]

Status: VERIFIED FIXED

(WebExtensions :: Frontend, defect)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

As a followup to the fix from Bug 1786564:

If an extension (e.g. TreeStyleTabs) has private browsing access and tries to access a static theme resource in a private browsing window:

• it works fine if the theme is a builtin theme (e.g. Firefox Alpenglow)
• it doesn't if the theme is a third party static theme (e.g. one of the theme mentioned in Bug 1786564 comment 22)

See Bug 1786564 comment 22 for a more detailed STR.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1711168

:mixedpuppy, since you are the author of the regressor, bug 1711168, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Clearing needinfo, because I'm already looking into this.

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1790115 - allow static theme resources in other extensions also in private browsing windows. r?mixedpuppy!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36431cf6a327
allow static theme resources in other extensions also in private browsing windows. r=mixedpuppy

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/36431cf6a327

Comment 6

[Alex Cornestean]

Verified as Fixed on the latest Nightly (106.0a1/20220914213649) under Windows 10 x64 and macOS 12.4.

Verified with the following themes:

• (https://addons.mozilla.org/en-US/firefox/addon/save-the-bees-plz/?utm_source=addons.mozilla.org&utm_medium=referral&utm_content=rating)
• https://addons.mozilla.org/en-US/firefox/addon/orchidestra/
• https://addons.mozilla.org/en-US/firefox/addon/american-style-4th-of-july/

The theme styling is properly applied to the sidebar in Private Browsing mode, confirming the fix. For further details, see the attached screenshot.

Comment 7

[Alex Cornestean]

Attachment: 2022-09-15_11h28_21.png

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Is this something we wanted to get into the scheduled dot release on 4-Oct or is riding the 106 train enough?

Comment 9

[Luca Greco [:rpl] [:luca] [:lgreco]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #8)

Is this something we wanted to get into the scheduled dot release on 4-Oct or is riding the 106 train enough?

Yes, given that it is a low risk one-line followup fix to Bug 1786564 (the patch is basically 99% test case) for a regression introduced in 105 (we would requested an uplift to beta but we were already past the last beta build and so it was too late for that), it would be nice to include it in a 105 dot release if we have one scheduled.

Comment 10

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 9293998 [details]
Bug 1790115 - allow static theme resources in other extensions also in private browsing windows. r?mixedpuppy!

Beta/Release Uplift Approval Request

• User impact if declined: Same as Bug 1786564 comment 15 but only from extension pages running as part of private browsing windows (e.g. an extension sidebar page part of a private browsing window).
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Same STR used to verify the fix in Nightly.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): low risk one line followup fix to Bug 1786564 (which has been already uplifted to 105 during the beta cycle), automated test included in the patch.
  The fix also been also explicitly QA verified in Nightly 106.
• String changes made/needed: -
• Is Android affected?: No

Comment 11

[Alex Cornestean]

Hello,

For consistency and continuity, I’ve verified the fix on the latest Beta (106.0b4/20220925185751) under Windows 10 x64 and Ubuntu 16.04 LTS.

Tested several themes and can confirm that theme styling is properly applied to the sidebar in Private Browsing mode on Beta. For more details, see the attached screenshot.

Once the fix lands in Release 105 via the dot release, I will check there as well and update the report accordingly.

Comment 12

[Alex Cornestean]

Attachment: 2022-09-26_11h44_08.png

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9293998 [details]
Bug 1790115 - allow static theme resources in other extensions also in private browsing windows. r?mixedpuppy!

Approved for 105.0.2.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/c73a6d4de77e

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Added to the 105.0.2 release notes:

Fixed a bug causing theme styling to not be properly applied to sidebars for some add-ons in Private Browsing Mode

Comment 16

[Alex Cornestean]

Verified as Fixed on the latest Release (105.0.2/20221003135607). Tested on Windows 10x64 and Ubuntu 16.04 LTS.

Verified with several themes and the styling is properly applied to the sidebar in Private Browsing mode, confirming the fix. For further details, see the attached screenshot.

Comment 17

[Alex Cornestean]

Attachment: 2022-10-04_10h06_22.png