1790138 - overscroll-behavior.html passes its assertion messages to the wrong function, so they're dropped & don't show up in logs

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect, P3)

Description

[Daniel Holbert [:dholbert]]

WPT test css/css-overscroll-behavior/overscroll-behavior.html uses an async testharness.js test, and passes in some helpful messages for each section in the test.step section, but it does so improperly such that the messages don't show up.

The test logging is like this:

var test = async_test("overscroll-behavior prevents scroll-propagation in the area and direction as specified");
[...]
  test.step(function() {
    assert_equals(root.scrollTop, 100);
    assert_equals(root.scrollLeft, 0);
    window.scrollTo(0, 0);
  }, "overscroll-behavior-y: none should only prevent scroll propagation on y axis.");

The test is passing the explanation string there as the final arg to the test.step(...) function; but test.step(...) does not take any such arg, as documented here:
https://web-platform-tests.org/writing-tests/testharness-api.html#Test.step

So the string never shows up in the logs when the test fails; we just get the top-level message that was passed to async_test() and that's it.

Really, the explanatory string should be passed to each assert_equals() invocation -- that function does accept a description final-arg:
https://web-platform-tests.org/writing-tests/testharness-api.html#assert_equals

Comment 1

[sayuree]

Attachment: Bug 1790138 - Edit test.step() and assertion messages r=botond

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 4

[Ivan]

May I please take this bug? :) Am I correct in saying that the suggestion was made, but was never worked on? I believe I understand what needs to be done.

Thanks!

Comment 5

[Botond Ballo [:botond]]

(In reply to Ivan from comment #4)

May I please take this bug? :) Am I correct in saying that the suggestion was made, but was never worked on? I believe I understand what needs to be done.

Sure! All that remains to be done is to address the latest comments on the patch.

Comment 6

[Ivan]

(In reply to Botond Ballo [:botond] from comment #5)

(In reply to Ivan from comment #4)

May I please take this bug? :) Am I correct in saying that the suggestion was made, but was never worked on? I believe I understand what needs to be done.

Sure! All that remains to be done is to address the latest comments on the patch.

Thank you Botond! Could you please assign it to me to track?

Comment 7

[Ivan]

Attachment: Bug 1790138 - Move assertion messages from test.step() into assertion functions in overscroll-behavior.html r=botond

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee96b4d088d9
Move assertion messages from  test.step() into assertion functions in overscroll-behavior.html r=botond

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/39567 for changes under testing/web-platform/tests

Comment 10

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/ee96b4d088d9

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 12

[Botond Ballo [:botond]]

Attachment: Bug 1790138 - Fix typo in overscroll-behavior.html WPT. r=hiro

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b489f4e43c1
Fix typo in overscroll-behavior.html WPT. r=hiro

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/39833 for changes under testing/web-platform/tests

Comment 15

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/3b489f4e43c1

Comment 16

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot