Open Bug 1790173 Opened 2 years ago Updated 2 years ago

Don't scroll within the bookmarks manager when using the expand/collapse buttons

Categories

(Firefox :: Bookmarks & History, defect, P3)

Product:
Firefox
Component:
Bookmarks & History
Version:
Firefox 102
Type:
defect

Tracking

()

People

(Reporter: thunderstone135, Unassigned)

References

Details

(Keywords: papercut, Whiteboard: [snt-scrubbed][places-papercut])

Steps to reproduce:

  1. Open Firefox
  2. Open Bookmarks Manager
  3. Expand All Bookmarks > Bookmarks Menu
    Note: Make sure to have a lot of folders inside the Bookmarks Menu.

Actual results:

I just want to report about the left side panel of the Bookmarks Manager instantly scrolling down to the bottom when I expand All Bookmarks > Bookmarks Menu. I was able to reproduce this behavior both on an existing and fresh profile. In Firefox 91 ESR, no scrolling happens when I open the Bookmarks Manager. I'm not sure if this is intentional or just a bug, but I'm just used to opening the Bookmarks Manager without any instant scrolling.

Expected results:

When opening the Bookmarks Manager and expanding folders/items, it should not scroll down to the bottom. Hopefully, this gets resolved within the Firefox 102 ESR update schedule. Otherwise, it would probably be years before this issue gets attention.

The Bugbug bot thinks this bug should belong to the 'Firefox::Bookmarks & History' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Bookmarks & History

When the Library window is opened, "Other Bookmarks" folder is initially selected (per Bug 1098468).
And next, when you expand the Bookmarks Menu folder, the tree will automatically scroll so that the selected item "Other Bookmarks" is in the view.

The problem with that is I'm not even selecting "Other Bookmarks." The item/folder I'm selecting is in the "Bookmarks Menu."
Here's a screenshot of my Bookmarks Manager. If you view the screenshot, you'll see that there's nothing inside Other Bookmarks.
In previous versions of Firefox, it doesn't scroll down to the bottom like that.
Just imagine if you have around a hundred folders and it scrolled down to the bottom.

By the way, I just reviewed the bug you mentioned. I noticed that it was for Firefox 46.
Since the bug was reported 7 years ago, then why is the issue I reported not happening in Firefox 91 ESR?
It really doesn't matter to me if "Other Bookmarks" is selected as long as there's no instant scrolling to the bottom.

The severity field is not set for this bug.
:mak, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(mak)

The workaround here is to select the folder before expanding it.

For fixing this, we would need to be careful not to break drag and drop situations. We could possibly not keep the original selection visible when expanding, but keep the selection (Windows does this - we should check the other OSes as well).

Severity: -- → S3
Flags: needinfo?(mak)
Keywords: papercut
Priority: -- → P3

I don think the workaround will have much of an impact if the Bookmarks Menu is left expanded in a previous session. What I mean is if I previously expanded the Bookmarks Menu and just left it open, the next time I open the Bookmarks Manager, the instant scroll to the bottom will inevitably happen. This is because I don't have a habit of collapsing the Bookmarks Menu when I'm done opening bookmarks. I have been doing this even before the advent of Firefox (when it was still Phoenix), so it's a habit that will be hard to change, especially if said habit is not even a bad one. That's why I mentioned in my previous comment that "It really doesn't matter to me if "Other Bookmarks" is selected as long as there's no instant scrolling to the bottom." I don't know when it started, but what I know for sure is it didn't happen in Firefox 91 ESR and just happened later on. That's why I was confused when someone mentioned Bug 1098468 because the instant scrolling was supposedly introduced in Firefox 46. If the issue I'm raising is related to that bug, then I should have already experienced the instant scrolling even before Firefox 91 ESR, which is definitely not the case.

By the way, when I open the Bookmarks Sidebar, there's no instant scrolling down to the bottom. Furthermore, no scrolling happens whether ornot the Bookmarks Menu is expanded. With that said, why not make it consistent and remove the instant scrolling in the Bookmarks Manager just like how it was in the previous versions? I do hope that Mozilla is not trying to get rid of the Bookmarks Manager in the future because that is the vibe I'm getting.

(In reply to thunderstone135 from comment #7)

I don think the workaround will have much of an impact if the Bookmarks Menu is left expanded in a previous session. What I mean is if I previously expanded the Bookmarks Menu and just left it open, the next time I open the Bookmarks Manager, the instant scroll to the bottom will inevitably happen.

When opening the Library the idea is to ensure the selection is in focus, that's unlikely to change.
Though if the Library is already open, and you use expanders, as Mark said already, we could evaluate not changing the scrolling position.

(In reply to thunderstone135 from comment #8)

I do hope that Mozilla is not trying to get rid of the Bookmarks Manager in the future because that is the vibe I'm getting.

Nope, it may change visually and likely move into a tab, but there will always be a bookmark manager as far as bookmarks exist.

When opening the Library the idea is to ensure the selection is in focus, that's unlikely to change.

I have no problem with that. It was discussed in Bug 1098468 after all.

we could evaluate not changing the scrolling position.

That's good to hear. Hopefully, the old behavior of no instant scrolling gets restored.
If it gets restored, it will make it consistent with the behavior of the Bookmarks Sidebar.

Nope, it may change visually and likely move into a tab, but there will always be a bookmark manager as far as bookmarks exist.

If that's the case, you will get no complaints from me. Placing the Bookmarks Manager inside a tab is a great idea.

I'm not able to reproduce this issue on Firefox 102.3.0esr and Firefox 105.0.3 on Windows 10 x64.
The scrolling in Library section is working as described in Comment 2.

I'm not able to reproduce this issue on Firefox 102.3.0esr and Firefox 105.0.3 on Windows 10 x64.

Instant scrolling to the bottom is not the original behavior of the Bookmarks Manager.
Firefox 91 ESR and below is my proof for that. I don't use regular versions so I'm not sure when it started.

The scrolling in Library section is working as described in Comment 2.

Which should not be the case. Hence, my reply in Comment 3 and Comment 4.
I would not have reported this issue If instant scrolling to the bottom was the original behavior of Firefox.

Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Bookmarks Manager Scrolling Issue → Don't scroll within the bookmarks manager when using the expand/collapse buttons
Whiteboard: [snt-scrubbed][places-papercut]
You need to log in before you can comment on or make changes to this bug.