1790312 - Clean up in nsFlexContainerFrame::ReflowChildren()

Status: RESOLVED FIXED

(Core :: Layout: Flexbox, task)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

See patches for details.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1790312 Part 1 - Make aFramePos parameter const for ReflowFlexItem(). r?dholbert

aFramePos is never modified in ReflowFlexItem().

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1790312 Part 2 - Remove flex item's normal position snapshot in ReflowChildren(). r?dholbert

ReflowChildren() only cares about the flex item's normal position, so we don't
need to output the relative position from MoveFlexItemToFinalPosition().

By making aFramePos const for MoveFlexItemToFinalPosition, we can delete
itemNormalBPos because framePos cannot be changed after calling
MoveFlexItemToFinalPosition.

This patch shouldn't change the behavior.

Depends on D157078

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8dc9c643baed
Part 1 - Make aFramePos parameter const for ReflowFlexItem(). r=dholbert
https://hg.mozilla.org/integration/autoland/rev/7e46c0198984
Part 2 - Remove flex item's normal position snapshot in ReflowChildren(). r=dholbert

Comment 4

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/8dc9c643baed
https://hg.mozilla.org/mozilla-central/rev/7e46c0198984