wrong side of scrollbar of inspector in RTL
Categories
(DevTools :: Inspector, defect, P3)
Tracking
(Not tracked)
People
(Reporter: amiadb, Unassigned, NeedInfo)
Details
(Keywords: rtl)
Attachments
(1 file)
|
52.21 KB,
image/jpeg
|
Details |
sb.jpeg
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:104.0) Gecko/20100101 Firefox/104.0
Steps to reproduce:
I open the inspector on Firefox in Hebrew.
Actual results:
The scrollbar of middle column in left side although the column is LTR becaouse the content in English.
Expected results:
The scrollbar in right side.
|
||
Comment 1•3 years ago
|
||
The Bugbug bot thinks this bug should belong to the 'DevTools::Inspector' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.
|
||
Comment 2•3 years ago
•
|
||
Headers inside this column should still be RTL, which is why the container is RTL overall. Will check if they are missing from this locale.
|
|
||
Comment 3•3 years ago
|
||
Discussed with :Itiel on elements about this.
To explain my reasoning here: the "rule view" panel is made of headers (eg "inherited from html" in the screenshot) and rules. The rules are forced to be in LTR at https://searchfox.org/mozilla-central/rev/0948667bc62415d48abff27e1405fb4ab4d65d75/devtools/client/themes/rules.css#266. But the Rule View as a whole is still following the locale's direction.
I mentioned the missing localization here, because "inherited from html" should be localized, and I assumed that if this key was localized, the position of the scrollbar would feel more appropriate.
But after discussing about this on elements, the problem is also about the fact that the scrollbar position overlays the rules if you are using floating scrollbars, making the panel harder to use.
Considering that most of the RuleView is already LTR, we can force the whole thing to be LTR and only preserve the direction for the headers.
A similar treatment can be applied to the Computed view, where we can simply move the dir=ltr from https://searchfox.org/mozilla-central/rev/0948667bc62415d48abff27e1405fb4ab4d65d75/devtools/client/inspector/index.xhtml#148 to https://searchfox.org/mozilla-central/rev/0948667bc62415d48abff27e1405fb4ab4d65d75/devtools/client/inspector/index.xhtml#146
The downside is that the Computed View (and the Rule View, when using 2 pane mode) can be replaced by other side panels, which will still be in RTL. So you might see the scrollbar jump from one side to the other when switching tabs.
Keeping the ni?, will provide a patch and we can discuss in the review.
|
|
||
Comment 4•3 years ago
|
||
The downside is that the Computed View (and the Rule View, when using 2 pane mode) can be replaced by other side panels, which will still be in RTL. So you might see the scrollbar jump from one side to the other when switching tabs.
Thinking about this, if the main concern is readability, another option is to add some margin so that the scrollbar doesn't overlay the content.
Description
•