1790347 - in retained display list code expand root frame rect for dynamic toolbar

Status: NEW

(Core :: Web Painting, defect, P3)

Description

[Timothy Nikkel (:tnikkel)]

This is a follow up to bug 1772859. When the dynamic toolbar on android is active the overflow rect of the rootframe will not include the part of the page that would be covered by the dynamic toolbar, even if the toolbar is not currently visible. So if we use the overflow rect of the root frame we need to expand it for the dynamic toolbar area. No specific testcase that I know if, just noticed this after bug 1772859.

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1790347. Expand the overflow rect of the root reference frame for painting if the dynamic toolbar is active. r?mstange

This is a follow up to bug 1772859. When the dynamic toolbar on android is active the overflow rect of the rootframe will not include the part of the page that would be covered by the dynamic toolbar, even if the toolbar is not currently visible. So if we use the overflow rect of the root frame we need to expand it for the dynamic toolbar area. No specific testcase that I know if, just noticed this after bug 1772859.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:tnikkel, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:tnikkel, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.