1790580 - Let touchpad swipe-to-navigate ride the trains to release on Linux

Status: RESOLVED FIXED

(Core :: Panning and Zooming, enhancement)

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1790580. Let touchpad swipe-to-navigate ride the trains to release on Linux. r?hiro

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/256356ca77a8
Let touchpad swipe-to-navigate ride the trains to release on Linux. r=hiro

Comment 3

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/256356ca77a8

Comment 4

[carlo]

is there an issue to follow for 1:1 swipe-to-navigate gestures, perhaps?

One-to-one gestures are gestures that follow your finger with the animation. In this case i was thinking of actually showing/previewing the next/previous page during the animation instead of showing a big arrow

Comment 5

[Botond Ballo [:botond]]

(In reply to carlo from comment #4)

is there an issue to follow for 1:1 swipe-to-navigate gestures, perhaps?

One-to-one gestures are gestures that follow your finger with the animation. In this case i was thinking of actually showing/previewing the next/previous page during the animation instead of showing a big arrow

I'm not aware of an issue on file for showing a preview of the next/previous page, though I know some browsers do this on some platforms (e.g. Safari on Mac) -- please feel free to file one.

Note, the arrow should already "follow your finger" to some extent -- if you think it's not doing so well enough (independently of whether we show a preview), that's worth filing a separate bug about.

Comment 6

[Timothy Nikkel (:tnikkel)]

Release Note Request (optional, but appreciated)
[Why is this notable]: new user visible feature that has been requested for a while by a number of people
[Affects Firefox for Android]: no
[Suggested wording]: Swipe to navigate (two fingers on a touch pad swiped left or right to perform history back or forward) on Windows is now enabled.
[Links (documentation, blog post, etc)]: none

Note, we enabled this for Windows in bug 1758196, this the same request for linux.

Comment 7

[Botond Ballo [:botond]]

(In reply to Timothy Nikkel (:tnikkel) from comment #6)

[Suggested wording]: Swipe to navigate (two fingers on a touch pad swiped left or right to perform history back or forward) on Windows is now enabled.

s/Windows/Linux

Comment 8

[Pascal Chevrel:pascalc]

Does it work on X11 or xwayland or is it limited to wayland? Mozilla does not officially ship wayland builds yet although third parties do activate the wayland backend in their packaging.

Comment 9

[Timothy Nikkel (:tnikkel)]

Botond is better positioned to answer that.

Comment 10

[Botond Ballo [:botond]]

Native Wayland: works out of the box.

X11: works but only with MOZ_USE_XINPUT2=1 in the environment. (Same with kinetic scrolling and other features that rely on touchpads producing PanGestureInput.)

XWayland: does not appear to work. I'm not sure why.

Comment 11

[Pascal Chevrel:pascalc]

(In reply to Botond Ballo [:botond] [away until 09/25] from comment #10)

Native Wayland: works out of the box.

X11: works but only with MOZ_USE_XINPUT2=1 in the environment. (Same with kinetic scrolling and other features that rely on touchpads producing PanGestureInput.)

XWayland: does not appear to work. I'm not sure why.

Should we mention that in release notes if it doesn't work on default Mozilla builds or should we keep this note for when we actually ship Firefox Wayland in Mozilla release builds?

Comment 12

[Botond Ballo [:botond]]

The feature has received news coverage in articles like this one, making me believe that the user community would be interested in knowing about it even if it only works in some configurations:

https://www.omgubuntu.co.uk/2022/09/mozilla-firefox-105-new-features

To avoid making the release note too complicated, we could just say it works "on Wayland", and not mention the XInput2 stuff.

Comment 13

[Timothy Nikkel (:tnikkel)]

I think it works in default mozilla builds? I don't think I had to do anything special to test it in my own local build.

Comment 14

[Pascal Chevrel:pascalc]

(In reply to Timothy Nikkel (:tnikkel) from comment #13)

I think it works in default mozilla builds? I don't think I had to do anything special to test it in my own local build.

Wayland is not activated on release builds but is activated on Nightly for people with eligible configuration.

Comment 15

[Pascal Chevrel:pascalc]

I added the note to our beta release notes with this wording:

Swipe to navigate (two fingers on a touch pad swiped left or right to perform history back or forward) on Linux for users on Wayland.