Closed Bug 1790595 Opened 14 days ago Closed 8 days ago

Performance regression in `StyleSheetManager._getMediaRules`

Categories

(DevTools :: Style Editor, defect, P2)

defect

Tracking

(firefox-esr91 unaffected, firefox-esr102 unaffected, firefox104 unaffected, firefox105 unaffected, firefox106 fixed, firefox107 fixed)

RESOLVED FIXED
107 Branch
Tracking Status
firefox-esr91 --- unaffected
firefox-esr102 --- unaffected
firefox104 --- unaffected
firefox105 --- unaffected
firefox106 --- fixed
firefox107 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Patch from Bug 1788030 caused a performance regression on the styleeditor https://treeherder.mozilla.org/perfherder/alerts?id=35326

Regressions:

Ratio Test Platform Options Absolute values (old vs new)
14% damp custom.styleeditor.open.DAMP windows10-64-shippable-qr e10s fission stylo webrender 771.45 -> 879.01
13% damp custom.styleeditor.open.DAMP linux1804-64-shippable-qr e10s fission stylo webrender 801.07 -> 904.38
12% damp custom.styleeditor.open.DAMP linux1804-64-shippable-qr e10s fission stylo webrender-sw 789.05 -> 887.52
12% damp custom.styleeditor.open.DAMP macosx1015-64-shippable-qr e10s fission stylo webrender-sw 723.97 -> 812.24
12% damp custom.styleeditor.open.DAMP windows10-64-shippable-qr e10s fission stylo webrender-sw 785.04 -> 880.69
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c2224b54c672
[devtools] Fix performance regression in _getMediaRules. r=jdescottes.

Backed out changeset c2224b54c672 (Bug 1790595) for causing mochitest failures on test_styles-applied.html.
Backout link
Push with failures <--> c3
Failure Log

Flags: needinfo?(nchevobbe)

not sure what's happening
TV jobs seem fine with the test https://treeherder.mozilla.org/jobs?repo=try&revision=e06b69265768dc19d39297f396cb12d58313fd30 , and I was able to run the whole folder without issue

Flags: needinfo?(nchevobbe)
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e2e5c02c98e3
[devtools] Fix performance regression in _getMediaRules. r=jdescottes.
Status: ASSIGNED → RESOLVED
Closed: 8 days ago
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch

Comment on attachment 9294427 [details]
Bug 1790595 - [devtools] Fix performance regression in _getMediaRules. r=jdescottes.

Beta/Release Uplift Approval Request

  • User impact if declined: performance regression when opening DevTools StyleEditor panel
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): devtools panel performance fix for a function already covered by automated tests
  • String changes made/needed:
  • Is Android affected?: Yes
Attachment #9294427 - Flags: approval-mozilla-beta?

Comment on attachment 9294427 [details]
Bug 1790595 - [devtools] Fix performance regression in _getMediaRules. r=jdescottes.

106 perf regression, LGTM, approved for 106 beta 2, thanks.

Attachment #9294427 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

== Change summary for alert #35431 (as of Tue, 20 Sep 2022 21:02:41 GMT) ==

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
30% damp custom.styleeditor.reload.DAMP windows10-64-shippable-qr e10s fission stylo webrender-sw 812.95 -> 571.96
29% damp custom.styleeditor.open.DAMP macosx1015-64-shippable-qr e10s fission stylo webrender-sw 810.23 -> 574.69
29% damp custom.styleeditor.open.DAMP macosx1015-64-shippable-qr e10s fission stylo webrender 808.70 -> 575.16
27% damp custom.styleeditor.open.DAMP linux1804-64-shippable-qr e10s fission stylo webrender-sw 882.07 -> 642.88
27% damp custom.styleeditor.open.DAMP linux1804-64-shippable-qr e10s fission stylo webrender 893.87 -> 653.82
... ... ... ... ...
23% damp custom.styleeditor.reload.DAMP linux1804-64-shippable-qr e10s fission stylo webrender 739.50 -> 572.25

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=35431

Improvement recorded in DAMP, we are even faster than before the regression :)

You need to log in before you can comment on or make changes to this bug.