1790644 - Ensure settings are correctly preserved during experiments

Status: VERIFIED FIXED

(Firefox :: Search, task, P2)

Description

[Mark Banner (:standard8)]

We need to make sure the default engine settings are correctly preserved when running experiments.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1790644 - Ensure default search engine settings are correctly preserved during and after experiments. r?daleharvey

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35eccaa021cc
Ensure default search engine settings are correctly preserved during and after experiments. r=daleharvey

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/35eccaa021cc

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 9295621 [details]
Bug 1790644 - Ensure default search engine settings are correctly preserved during and after experiments. r?daleharvey

Beta/Release Uplift Approval Request

• User impact if declined: When an experiment runs and then finishes, we may not correctly reset the user's default search engine value.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce: QA are testing this as part of experiments.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The code only affects changes in and out of experiments. QA will be testing these scenarios
• String changes made/needed: None
• Is Android affected?: No

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9295621 [details]
Bug 1790644 - Ensure default search engine settings are correctly preserved during and after experiments. r?daleharvey

Approved for 106.0b6.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/1c2414ca9a3b

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 9295621 [details]
Bug 1790644 - Ensure default search engine settings are correctly preserved during and after experiments. r?daleharvey

Beta/Release Uplift Approval Request

• User impact if declined: When an experiment runs and then finishes, we may not correctly reset the user's default search engine value.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce: QA are testing this as part of experiments.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The code only affects changes in and out of experiments. QA will be testing these scenarios
• String changes made/needed: none
• Is Android affected?: No

Comment 8

[Adrian Florinescu [:aflorinescu]]

Verified on Windows 10, Ubuntu 22.04 and Mac 11 using Nightly 107.0a1 (2022-09-29) and Beta 106.0b6.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9295621 [details]
Bug 1790644 - Ensure default search engine settings are correctly preserved during and after experiments. r?daleharvey

Approved for 105.0.2.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/fac92ac0a062

Comment 11

[Petruta Horea [:phorea]]

Verified as fixed with 105.0.2 on Ubuntu 22.04, Mac 11 and Windows 10.