1790748 - libudev-sys should implement Send trait

Status: RESOLVED FIXED

(Core :: DOM: Web Authentication, defect, P1)

Description

[Makoto Kato [:m_kato]]

When adding a crate in mozilla-central that uses lazy_static with spin_no_std, we cannot compile libudev-sys in dom/webauthn/libudev-sys.

 0:18.61    Compiling libudev-sys v0.1.3 (/mozilla/mozilla-central/dom/webauthn/libudev-sys)
 0:19.28 error[E0277]: `*mut c_void` cannot be sent between threads safely
 0:19.28   --> dom/webauthn/libudev-sys/src/lib.rs:78:1
 0:19.28    |
 0:19.29 78 | / lazy_static! {
 0:19.29 79 | |   static ref LIBRARY: Library = {
 0:19.29 80 | |     Library::open("libudev.so.1")
 0:19.29 81 | |   };
 0:19.29 82 | | }
 0:19.29    | |_^ `*mut c_void` cannot be sent between threads safely
 0:19.29    |
 0:19.29    = help: within `Library`, the trait `Send` is not implemented for `*mut c_void`
 0:19.29 note: required because it appears within the type `Library`
 0:19.29   --> dom/webauthn/libudev-sys/src/lib.rs:50:8
 0:19.29    |
 0:19.29 50 | struct Library(*mut c_void);
 0:19.29    |        ^^^^^^^
 0:19.29    = note: required because of the requirements on the impl of `Sync` for `spin::once::Once<Library>`
 0:19.29    = note: required because it appears within the type `lazy_static::lazy::Lazy<Library>`
 0:19.29    = note: shared static variables must have a type that implements `Sync`
 0:19.29    = note: this error originates in the macro `__lazy_static_create` (in Nightly builds, run with -Z macro-backtrace for more info)
 0:19.29 error[E0277]: `*mut c_void` cannot be sent between threads safely
 0:19.29    --> dom/webauthn/libudev-sys/src/lib.rs:124:1
 0:19.29     |
 0:19.29 124 | define!(udev_new, extern "C" fn () -> *mut udev);
 0:19.29     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ `*mut c_void` cannot be sent between threads safely
 0:19.29     |
 0:19.29     = help: within `Symbol<extern "C" fn() -> *mut udev>`, the trait `Send` is not implemented for `*mut c_void`
 0:19.29 note: required because it appears within the type `Symbol<extern "C" fn() -> *mut udev>`
 0:19.29    --> dom/webauthn/libudev-sys/src/lib.rs:84:12
 0:19.29     |
 0:19.29 84  | pub struct Symbol<T> {
 0:19.29     |            ^^^^^^
 0:19.29     = note: required because of the requirements on the impl of `Sync` for `spin::once::Once<Symbol<extern "C" fn() -> *mut udev>>`
 0:19.29     = note: required because it appears within the type `lazy_static::lazy::Lazy<Symbol<extern "C" fn() -> *mut udev>>`
 0:19.29     = note: shared static variables must have a type that implements `Sync`
 0:19.29     = note: this error originates in the macro `__lazy_static_create` (in Nightly builds, run with -Z macro-backtrace for more info)
...

Comment 1

[Makoto Kato [:m_kato]]

ICU4X uses lazy_static with spin_no_std, so when adding it, this issue occurs.

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Bug 1790748 - Add Send trait implementation in libudev-sys. r=dveditz

When adding a crate in mozilla-central that uses lazy_static with spin_no_std,
we cannot compile libudev-sys in dom/webauthn/libudev-sys.

lazy_static might require Send trait for some struct, so we should add it.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:rmf, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cbab48d429cc
Add Send trait implementation in libudev-sys. r=dveditz

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/cbab48d429cc