1790821 - Can't resize the devtools toolbox when it's docked to the right

Status: VERIFIED FIXED

(DevTools :: Framework, defect)

Description

[Julien Wajsberg [:julienw]]

STR:

1. Open the devtools toolbox.
2. Make sure it's docked to the right.
3. Try to resize it.

=> KO

Broken in Nightly v106 20220914040922
Working in Nightly v106 20220908092810

I'll run mozregression to pinpoint the problem.

Comment 1

[Julien Wajsberg [:julienw]]

mozregression gives this pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d7a22e2e4f136ab8bcc2847cfcdc3731f5b4b0d0&tochange=3c1db9604720cc9b32b86ffb0ba682a29987c457

Which seems to point to Bug 1790299, which makes sense.

Emilio, what do you think?

I see you pushed an update to bug 1790299, is that to fix this issue?

Comment 2

[Julien Wajsberg [:julienw]]

or rather the patch in bug 1790712

Comment 4

[Julian Descottes [:jdescottes]]

Thanks for filing and sorry for missing that in the review.

It feels like Bug 1790712 is a workaround, to keep using the attribute for now.
I think we should update the implementation side-docked toolboxes to use the style.width, in the same way as the bottom toolbox.
And add a test.

Comment 5

[Julian Descottes [:jdescottes]]

I would like to reopen to fix the DevTools toolbox code for side docked toolboxes and add tests.

Comment 6

[Julian Descottes [:jdescottes]]

Attachment: Bug 1790821 - [devtools] Fix resizing side-docked toolbox using the splitter

Adding a test explicitly resizing the toolbox by manipulating the splitter in both horizontal and vertical configurations

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'DevTools::Framework' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00779d3e486a
[devtools] Fix resizing side-docked toolbox using the splitter r=ochameau,emilio

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/00779d3e486a

Comment 10

[Giorgia Nichita, Release Desktop QA]

I've reproduced this issue on an affected nightly build from 2022-09-13, on Win 10.
Verified as fixed on Firefox 106.0 (20221010110315) on Win 10, Ubuntu 21.04 and mac0S 10.15.