Closed Bug 1790851 Opened 2 years ago Closed 2 years ago

Vendor libprio-rs into Fx

Categories

(Toolkit :: Telemetry, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
106 Branch
Tracking Status
firefox106 --- fixed

People

(Reporter: simonf, Assigned: simonf, Mentored)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

libprio-rs will be doing the heavy lifting for our DAP

Pushed by brennie@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c1bdc6dd22b6 Add libprio-rs dependency. r=emilio,supply-chain-reviewers
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch

Just FTR, I suspect this was the trigger for a mysterious build error I encountered today after rebasing on central:

 5:53.84 error[E0308]: mismatched types
 5:53.84    --> /Users/jkew/mozdev/mozilla-unified/third_party/rust/prio/src/field.rs:260:45
 5:53.84     |
 5:53.84 256 |     fn valid_integer_try_from<N>(i: N) -> Result<Self::Integer, FieldError>
 5:53.84     |                               - this type parameter
 5:54.07 ...
 5:54.07 260 |         let i_int = Self::Integer::try_from(i).map_err(|_| FieldError::IntegerTryFrom)?;
 5:54.07     |                     ----------------------- ^ expected `usize`, found type parameter `N`
 5:54.07     |                     |
 5:54.07     |                     arguments to this function are incorrect
 5:54.07     |
 5:54.07     = note:        expected type `usize`
 5:54.07             found type parameter `N`
 5:54.07 note: associated function defined here
 5:54.43 For more information about this error, try `rustc --explain E0308`.
 5:54.44 error: could not compile `prio` due to previous error

After a bit of head-scratching, I tried running rustup update, and the error has gone away. So it looks like a slightly outdated Rust version didn't like this, but the build system didn't know to flag it.

(In reply to Jonathan Kew [:jfkthame] from comment #4)

After a bit of head-scratching, I tried running rustup update, and the error has gone away. So it looks like a slightly outdated Rust version didn't like this, but the build system didn't know to flag it.

Same problem here, thank you for the workaround

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: