1790913 - DOS - The long parameter hangs the Fenix homepage, making Fenix unusable

Status: RESOLVED FIXED

(Fenix :: General, defect, P3)

Description

[Chris Peterson [:cpeterson]]

+++ This bug was initially created as a clone of Bug #1759951 +++

As Irwan reported in bug 1759951 comment 47, this bug is still reproduce with different STR. Since the toolbar hang with the original STR was fixed, I'm opening this new homepage bug for the new STR.

On Firefox 104 and Nightly 106 on a Samsung Galaxy A32 (a mid-range device) running Android 12:

1. Open this bug in Firefox.
2. Click the link this bug's URL field.
3. Firefox loads the "494 ERROR" page in a new tab without freezing. 🙂
4. Close the "494 ERROR" tab and return the Bugzilla tab.
5. Close the Bugzilla tab, returning to Firefox's home page.
6. Then Firefox hangs. 🥶
7. Force quit Firefox and launch it again.
8. Firefox hangs again on the home page. 🥶

To recover, I have to clear Firefox's app storage data in Android's Settings.

csadilek debugged this homepage hang and says (in bug 1759951 comment 50):

The original patch here fixed the problem occurring in the toolbar, but I created a new profile based on Chris's STR, and it shows the same problem now being hit on the home fragment. We're hitting Android's android.graphics.text.LineBreaker.nComputeLineBreaks again which blocks for an extended period of time.

Let's truncate long URLs on all home screen sections, and also write an extension function so we don't keep running into this with new functionality.

Comment 1

[Irwan]

Thank @chris,
Have opened this issue separately.

So when will the fixes be implemented?

Regards, @irwan

Comment 2

[Chris Peterson [:cpeterson]]

sec-moderate -> P3

Comment 3

[Chris Peterson [:cpeterson]]

sec-moderate -> S3

Comment 4

[Irwan]

Hi, any updates?
I see the version has 106.1.0 (Build #2015909131), the bug is still working?

Comment 5

[[:skhan]]

Bug is fixed and should be available in nightly version 108

Comment 6

[Irwan]

thanks @sarah, On confirmation.

Comment 7

[[:skhan]]

Attachment: 0001-Create-extension-for-truncating-urls.patch

Hi, I am attaching two patches for review.

Comment 8

[[:skhan]]

Attachment: 0001-Truncate-urls-to-prevent-slowing-down-of-UI.patch

Comment 9

[Chris Peterson [:cpeterson]]

(In reply to Sarah from comment #5)

Bug is fixed and should be available in nightly version 108

In that case, I will resolve this bug as fixed in 108.

I'm leaving this fixed bug private until we verify whether this fix also fixed bug 1759951.

Comment 10

[Daniel Veditz [:dveditz]]

Per bug 1759951 comment 50 the original fix didn't cover the whole problem, so this additional aspect should have also gotten a bounty nomination