1791069 - Not clamping baseline position when scrollable overflow gives weird results

Status: RESOLVED FIXED

(Core :: Layout: Scrolling and Overflow, defect)

Description

[Mozilla Apprentice]

A resolution was made for csswg-drafts/#7660.

Not clamping baseline position when scrollable overflow gives weird results

• RESOLVED: baselines of a scrollable container should be clamped to the scrollable area

Discussion.

Comment 1

[Daniel Holbert [:dholbert]]

This might be in dshin's wheelhouse, given he's been looking at both scrolling and baselines in the recent past.

Comment 2

[David Shin[:dshin]]

Attachment: Bug 1791069 - Clamp scrollable element's first/last baseline position to border box. r=#layout-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/33ba5e2e97b1
Clamp scrollable element's first/last baseline position to border box. r=emilio

Comment 4

[Atila Butkovits]

Backed out for causing failures at grid-align-baseline-line-clamp-002.tentative.html.

Backout link: https://hg.mozilla.org/integration/autoland/rev/4072b936fce7da353ea1b21a5bd021a8499cd7ea

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=FqicaMGIT42j-hNtqt2-7g.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=33ba5e2e97b15f381d12fa96d3cc6c972b15c86e

Failure log: https://treeherder.mozilla.org/logviewer?job_id=395983852&repo=autoland&lineNumber=1742

Comment 5

[David Shin[:dshin]]

Unexpected pass on android without fission. Interesting. Adjusting test expectations.

Comment 6

[David Shin[:dshin]]

Landing queued

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27903633c625
Clamp scrollable element's first/last baseline position to border box. r=emilio

Comment 8

[Noemi Erli[:noemi_erli]]

Backed out changeset 27903633c625 (Bug 1791069) for causing web-platform failures CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=PNlAixFoTXOqHkT6rA1SfA.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=27903633c6254fc903539fa0c5e11c02103e169e

Log: https://treeherder.mozilla.org/logviewer?job_id=396075658&repo=autoland&lineNumber=1681

Backout: https://hg.mozilla.org/integration/autoland/rev/804292d1b538c3d39674b9a0647141c8d24fec43

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d55e22227807
Clamp scrollable element's first/last baseline position to border box. r=emilio

Comment 10

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c49bf65cd85a
Backed out changeset d55e22227807 for wpt failures on negative-overflow-002.html. CLOSED TREE

Comment 11

[David Shin[:dshin]]

Ah, there should've been a writing mode conversion.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a748bc656e65
Clamp scrollable element's first/last baseline position to border box. r=emilio

Comment 13

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/a748bc656e65