179117 - Increase number of URL bar dropdown menu items and decouple from number of history items

Status: RESOLVED FIXED

(SeaMonkey :: Location Bar, enhancement)

Description

[Steve Chapel]

Currently, Mozilla uses a maximum of 15 items for the history lists (Back,
Forward, and Go menus) and also the URL bar dropdown menu. This doesn't seem to
be as much by design as it is that the const MAX_HISTORY_MENU_ITEMS in
sessionHistoryUI.js is used for both purposes. Two different consts should be
declared for the two different uses.

Additionally, I don't see any reason for showing only 15 items in the dropdown.
There's a scrollbar, so showing more entries will not take any more screen space
or force a scrollbar to appear more often than with 15 entries. Perhaps a
maximum of 30 entries would be more appropriate.

Comment 1

[Steve Chapel]

Attachment: Patch to increase URL dropdown to 30 items

Comment 2

[Asa Dotzler [:asa]]

Comment on attachment 105650 [details] [diff] [review]
Patch to increase URL dropdown to 30 items

Jag, can you sr (and module owner review) this patch?

Comment 3

[jag (Peter Annema)]

I think 30 items in the back/forward menubutton dropdown is too much. 15 items
already fills half my screen, 30 would fill my whole screen and be way more back
history than I typically want access to (read: be overwhelming). I agree however
that the urlbar dropdown menu should have more than 15.

Comment 4

[Boris 'pi' Piwinger]

Maybe I miss something, but isn't this here a dupe of bug 62010 as far as
back/forward/go are concerned?

Per the previous comment: Why should the menu not fill all of the screen? I
regularly would like to go that far back, it often happens with frames, where
you get long lists and have practically no chance to go back to the previous
(i.e., before entering the frames) page (especially combined with those bugs
which say that back does not work).

pi

Comment 5

[Steve Chapel]

Yes, there is some overlap between this bug and my patch for bug 62010. I
thought a patch for this bug would be more easily accepted and would then
simplify the patch for the other bug.

As for the dropdown filling the entire window, my address bar dropdown displays
at most ten entries at any time. Any more than that, and a scrollbar appears. Is
the number of entries displayed platform dependant? If so, should this be fixed
so that the same number of entries appear in all platforms? Or should I just
increase the number of items to 20 instead of 30?

Comment 6

[Boris 'pi' Piwinger]

I never thought about the address bar dropdown. I thought the filling argument
is about the Go menu and the Back button. But again, I don't see the problem,
that is what they are good for.

pi

Comment 7

[Alec Flett]

Comment on attachment 105650 [details] [diff] [review]
Patch to increase URL dropdown to 30 items

now this is reasonable. sr=alecf

Comment 8

[Steve Chapel]

Could someone check this in for me? I don't have CVS access.

Comment 9

[(not reading, please use [e-mail] instead)]

Comment on attachment 105650 [details] [diff] [review]
Patch to increase URL dropdown to 30 items

a=sspitzer, since jag is ok with this:

"I agree however
that the urlbar dropdown menu should have more than 15."

Comment 10

[(not reading, please use [e-mail] instead)]

what happened here?  did this have r/sr/a for 1.4 beta, but never checked in?

Comment 11

[Asa Dotzler [:asa]]

Comment on attachment 105650 [details] [diff] [review]
Patch to increase URL dropdown to 30 items

a=asa (on behalf of drivers) for checkin to 1.4.

Comment 12

[Asa Dotzler [:asa]]

Has this landed yet? I don't see anything in bonsai. 

Comment 13

[Steve Chapel]

timeless just checked this in

Comment 14

[Jeff Leigh]

Still only seeing 15 items as of the 2003052708 build. What happened?

Comment 15

[Steve Chapel]

This did get checked in. I've got 30 items in the URL bar dropdown menu with the
2003050708 build on Windows 98.

What OS are you using? Can you attach a screenshot showing the problem?

Comment 16

[Jeff Leigh]

Attachment: 15 items in back menu with one lost at the bottom

Comment 17

[Jeff Leigh]

Attachment: back one page from previous pic, showing lost item

Comment 18

[Jeff Leigh]

I've added two screen shots that hopefully show the problem. I'm running this on
Windows 2000. I'll check the same build on Mac OS X when I get home from work. I
also tested it in both themes to rule that out.

Comment 19

[Jeff Leigh]

Sorry about that. I got the history menus and URL menu confused. Looks like Bug
62010 is what I really need for what I want.