1791178 - Digital storage size unit symbols not expressed according to the language set in Firefox if language changes (need to switch downloads.properties units to fluent)

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[lamalbrut]

Attachment: distinct_locale_for_digital_sizes.png

Hello. Digital storage size unit symbols are not expressed according to the language set in Firefox

Conditions:

• Linux OS locale: English non-alike.

In Firefox | in about:preferences#general

• language set: English (US)
• option Use your operating system settings for “suomi (Suomi)” to format dates, times, numbers, and measurements.: not checked.

Observed effects
in about:preferences#privacythe sizes reported in section Cookies and site Data the measure units are expressed according to my OS locale, not the language set in Firefox. Then either tavua or t, respectively for byte and bytes are exhibited instead of the correct forms which are byte and B.

Comment 1

[:Gijs (he/him)]

I expect you switched languages at runtime. We're loading the localized string for the byte units from your selected Firefox locale, so presumably it was originally set to Finnish and cached. I expect a restart of Firefox will fix it. If not, that would be interesting to know - as would knowing if using about:support and clicking "clear startup cache" there (followed by another restart) addresses it.

Comment 2

[lamalbrut]

Your assumption is correct. Observing the instructions addressed it. Then i learned something. I had assumed that the function about:preferences#privacy's Clear data was precisely to globally clear data at runtime as well the startup cache.

Comment 3

[:Gijs (he/him)]

(In reply to lamalbrut from comment #2)

I had assumed that the function about:preferences#privacy's Clear data was precisely to globally clear data at runtime as well the startup cache.

Right - "Clear data" is listed under "Cookies and Site Data" because it only removes website related data, not Firefox configuration/caching data. :-)

Comment 4

[:Gijs (he/him)]

Greg, for my edification: under what circumstances do .properties reads get updated at/after a live language switch? Although of course migrating this particular bit to Fluent will help, there are many of these cached bundle references in the codebase... did we consider wiping caches and invalidating previously fetched stringbundles at the point of a live language switch and/or are there reasons that's not possible?

Comment 5

[Greg Tatum [:gregtatum]]

The string bundles have multiple cache mechanisms, so it depends on the situation of how they get loaded as to how they get reloaded. There are a subset of bundles that get loaded into shared memory. These can never be changed until restart. If you hold a reference to a bundle, e.g. through a lazy loader, then these will never be updated. Many different parts of code hold on to a reference to the string bundle with their own retaining reference.

So in the case where you directly load a string bundle not in shared memory after a live language switch, you will get the new language's bundle.

Here is where SharedStringBundle is created: https://searchfox.org/mozilla-central/rev/a26af613a476fafe6c3eba05a81bef63dff3c9f1/intl/strres/nsStringBundle.cpp#895

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

Could we use https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/NumberFormat/NumberFormat#options style unit for unit formatting?

Comment 7

[Eemeli Aro [:eemeli]]

Attachment: Bug 1791178 - Use correct identifier for localized downloads forder. r=gijs!

This appears to have been a typo introduced in bug 1737926.

Comment 8

[Eemeli Aro [:eemeli]]

Attachment: Bug 1791178 - Convert nsContextMenu saveHelper() localization to Fluent. r=gijs!

These strings are only used from browser, so it doesn't make sense to keep them under toolkit.

Depends on D158465

Comment 9

[Eemeli Aro [:eemeli]]

Attachment: Bug 1791178 - Convert DownloadUtils.jsm to Fluent. r=gijs!

Depends on D158466

Comment 10

[Eemeli Aro [:eemeli]]

Attachment: Bug 1791178 - Convert DownloadUIHelper.sys.mjs to Fluent. r=gijs!

The downloadsFolder string is left in the downloads.properties file, at least for now, as it's also used from C++ code.

Depends on D158467

Comment 11

[Eemeli Aro [:eemeli]]

The stack of patches I just submitted for this does not use NumberFormat with style: "unit", as I couldn't find a way of doing so while retaining the same strings in all languages for download rates. At a brief glance, at least our Basque, Estonian and Tibetan translations use expressions for "foo of bar" that do not simply concatenate the value with its unit.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9122c36cdf19
Use correct identifier for localized downloads forder. r=Gijs

Comment 13

[Eemeli Aro [:eemeli]]

Landing just the typo fix for now; the rest of the stack will probably not land until 108, as I'll be away for a couple of weeks after this one.

Comment 14

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/9122c36cdf19

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fcd7f4dad307
Convert nsContextMenu saveHelper() localization to Fluent. r=Gijs,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/313e4bf53438
Convert DownloadUtils.jsm to Fluent. r=Gijs,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/cff746cab1b2
Convert DownloadUIHelper.sys.mjs to Fluent. r=Gijs,fluent-reviewers,flod

Comment 16

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/fcd7f4dad307
https://hg.mozilla.org/mozilla-central/rev/313e4bf53438
https://hg.mozilla.org/mozilla-central/rev/cff746cab1b2

Comment 17

[Ciprian Georgiu, Desktop QA]

Hi, lamalbrut! Could you please take a look at this bug and check if the issue is fixed on the latest Beta 108 builds?

Unfortunately, I was not able to reproduce the issue described in comment 0, using an affected Nightly build 2022-09-16, with Win 10 x64 or Ubuntu 18.04 x64.

Comment 18

[lamalbrut]

on | Windows 11. Firefox 109.0a1 (2022-11-19)

Unlike the behaviour in the version originally tested, in that version the newly selected language is not applied at all at runtime. Therefore there is no relevant observation to be made during runtime.