Closed Bug 1791405 Opened 3 years ago Closed 3 years ago

Fn key delete selection

Categories

(DevTools :: Source Editor, defect, P2)

defect

Tracking

(firefox107 verified)

VERIFIED FIXED
107 Branch
Tracking Status
firefox107 --- verified

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Steps to reproduce

  1. Open the console
  2. Type anything, e.g. firefox
  3. Select the text you just typed
  4. Hit the Fn key of your keyboard (Linux, Windows)

Actual result

The selection gets deleted, which can be very frustrating given how the key can be close to Ctrl

Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED

Nicolas: Discussing during triage, we think the fix is worth landing even if we don't have a good testing solution yet.

Severity: -- → S3
Flags: needinfo?(nchevobbe)
Priority: -- → P2
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7f81e81ddb4d [devtools] Block key events in source editor for u0000 keys. r=ochameau.
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch
Flags: needinfo?(nchevobbe)
Flags: qe-verify+

Hi, Nicolas! I have tried to reproduce this bug using an affected Nightly build (106.0a1, 2022-09-19) with Ubuntu 18.04 x64 and Win 10 x64, but for some reason the text selection does't get deleted when pressing the fn key. Do you know what I might be doing wrong?

Flags: needinfo?(nchevobbe)

(In reply to Ciprian Georgiu [:ciprian_georgiu], Release Desktop QA from comment #5)

Hi, Nicolas! I have tried to reproduce this bug using an affected Nightly build (106.0a1, 2022-09-19) with Ubuntu 18.04 x64 and Win 10 x64, but for some reason the text selection does't get deleted when pressing the fn key. Do you know what I might be doing wrong?

I think it doesn't reproduce with all keyboards (when we triaged the bug, it was reproducing for jdescottes for example).

Flags: needinfo?(nchevobbe)

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #6)

I think it doesn't reproduce with all keyboards (when we triaged the bug, it was reproducing for jdescottes for example).

Thanks!

Julian, can you please help us checking if the fix is working on latest Beta 107?

Flags: needinfo?(jdescottes)

I could not reproduce it either, I think in the team :nchevobbe and :ochameau could reproduce. Maybe :Honza as well?

Could one of you try to check if this is fixed on beta 107?

Flags: needinfo?(poirot.alex)
Flags: needinfo?(odvarko)
Flags: needinfo?(nchevobbe)
Flags: needinfo?(jdescottes)

I can reproduce in Fx 106
I can not reproduce in Fx 107 (DevEdition)

Tested on Win 10

Flags: needinfo?(odvarko)

Thanks for testing Honza! We can probably remove the other ni?

Flags: needinfo?(poirot.alex)
Flags: needinfo?(nchevobbe)

Great! Thanks as well!

Marking this bug as verified fixed per comment 9.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: