Closed Bug 1791438 Opened 4 months ago Closed 2 months ago

Update browser_tabCloseSpace to use overflowTabs() from BrowserTestUtils

Categories

(Firefox :: Keyboard Navigation, task, P3)

task

Tracking

()

RESOLVED FIXED
110 Branch
Tracking Status
firefox110 --- fixed

People

(Reporter: tgiles, Assigned: webdevbrinkman, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [lang=js])

Attachments

(1 file, 1 obsolete file)

Currently browser_tabCloseSpacer uses overflowTabs as defined in its own file. With the introduction of the shared-head.js file from Bug 1778450, this test should be changed to use the shared-head implementation instead. Trying to use shared-head.js resulted in having to fight the linter, so I moved the helper function into BrowserTestUtils instead. We should use the shared function from BrowserTestUtils.

Summary: Update browser_tabCloseSpace to use overflowTabs() from shared-head.js → Update browser_tabCloseSpace to use overflowTabs() from BrowserTestUtils

To help Mozilla out with this bug, here's the steps:

  1. Comment here on the bug that you want to volunteer to help.
    This will tell others that you're working on the next steps.
  2. Download and build the Firefox source code
    • If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
    • You can also read the Developer Guide, which has answers to most development questions.
  3. Start working on this bug.
    • As noted in Comment #0, you'll need to update the test to use BrowserTestUtils.overflowTabs() instead of the test's current implementation.
    • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #fx-desktop-dev channel on Element/Matrix most hours of most days.
  4. Build your change with mach build and test your change with mach test browser/base/content/test/tabs/browser_tabCloseSpacer.js --headless. Also check your changes for adherence to our style guidelines by using mach lint.
  5. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
  6. After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland.
Mentor: tgiles
Keywords: good-first-bug
Whiteboard: [lang=js]
Assignee: nobody → pluk
Status: NEW → ASSIGNED

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Assignee: pluk → nobody
Status: ASSIGNED → NEW

Hello, I would like to help on this ticket.

Hi Tyler, thanks for your help on this ticket! Please refer to Comment #1 for help getting started but feel free to needinfo me here or reach out to me on Matrix if you run into issues along the way!

Assignee: nobody → webdevbrinkman
Status: NEW → ASSIGNED
Pushed by tgiles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e9692ac46be2
Update browser_tabCloseSpace to use overflowTabs() from BrowserTestUtils r=tgiles
Attachment #9307234 - Attachment is obsolete: true
Pushed by tgiles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1a06da0367ca
Update browser_tabCloseSpace to use overflowTabs() from BrowserTestUtils r=tgiles
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 110 Branch
Flags: needinfo?(webdevbrinkman)
You need to log in before you can comment on or make changes to this bug.