1791438 - Update browser_tabCloseSpace to use overflowTabs() from BrowserTestUtils

Status: RESOLVED FIXED

(Firefox :: Keyboard Navigation, task, P3)

Description

[Tim Giles [:tgiles]]

Currently browser_tabCloseSpacer uses overflowTabs as defined in its own file. With the introduction of the shared-head.js file from Bug 1778450, this test should be changed to use the shared-head implementation instead. Trying to use shared-head.js resulted in having to fight the linter, so I moved the helper function into BrowserTestUtils instead. We should use the shared function from BrowserTestUtils.

Comment 1

[Tim Giles [:tgiles]]

To help Mozilla out with this bug, here's the steps:

1. Comment here on the bug that you want to volunteer to help.
   This will tell others that you're working on the next steps.
2. Download and build the Firefox source code
   • If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
   • You can also read the Developer Guide, which has answers to most development questions.
3. Start working on this bug.
   • As noted in Comment #0, you'll need to update the test to use BrowserTestUtils.overflowTabs() instead of the test's current implementation.
   • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #fx-desktop-dev channel on Element/Matrix most hours of most days.
4. Build your change with mach build and test your change with mach test browser/base/content/test/tabs/browser_tabCloseSpacer.js --headless. Also check your changes for adherence to our style guidelines by using mach lint.
5. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
   • How to Submit a Patch
   • This is when the bug will be assigned to you.
6. After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland.
   • If there are changes requested, please read the "To update a submitted patch" section to ensure you don't accidentally create a duplicate revision!
   • Your code will soon be shipping to Firefox users worldwide!

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 3

[Tyler Brinkman]

Hello, I would like to help on this ticket.

Comment 4

[Tim Giles [:tgiles]]

Hi Tyler, thanks for your help on this ticket! Please refer to Comment #1 for help getting started but feel free to needinfo me here or reach out to me on Matrix if you run into issues along the way!

Comment 5

[Tyler Brinkman]

Attachment: Bug 1791438 Update browser_tabCloseSpace to use overflowTabs() from BrowserTestUtils r=tgiles

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e9692ac46be2
Update browser_tabCloseSpace to use overflowTabs() from BrowserTestUtils r=tgiles

Comment 7

[Cosmin Sabou [:CosminS]]

Backed out changeset for causing bc failures on browser_tabReorder_overflow.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=e9692ac46be2b072d0f9c4d4d71abed5e778b416&selectedTaskRun=J48hqiY3SOCEzTcWmVBdMQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=398967115&repo=autoland
https://treeherder.mozilla.org/logviewer?job_id=398971351&repo=autoland&lineNumber=8311

Backout link: https://hg.mozilla.org/integration/autoland/rev/a05d78dc2db2423cb6a3a02b3017566f64c2c905

Comment 8

[Tyler Brinkman]

Attachment: Bug 1791438 Update browser_tabCloseSpace to use overflowTabs() from BrowserTestUtils r=tgiles

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a06da0367ca
Update browser_tabCloseSpace to use overflowTabs() from BrowserTestUtils r=tgiles

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/1a06da0367ca