1791439 - Update browser_tabReorder_overflow.js to use BrowserTestUtils.overflowTabs function

Status: RESOLVED FIXED

(Firefox :: Keyboard Navigation, task, P3)

Description

[Tim Giles [:tgiles]]

Currently, browser-tabReorder_overflow.js uses a custom implementation to cause the tabs to overflow. With the addition of the shared-head.js file in Bug 1778450, we can swap this custom logic out for the shared logic instead. Instead of the shared function being in shared-head.js, it now lives in BrowserTestUtils. Note: we want to keep newTab1, newTab2, and newTab3 intact. These three tabs should be spawned first and then we should call BrowserTestUtils.overflowTabs() to keep the previous test logic intact.

Comment 1

[Tim Giles [:tgiles]]

To help Mozilla out with this bug, here's the steps:

1. Comment here on the bug that you want to volunteer to help.
   This will tell others that you're working on the next steps.
2. Download and build the Firefox source code
   • If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
   • You can also read the Developer Guide, which has answers to most development questions.
3. Start working on this bug.
   • As noted in Comment #0, you'll need to update the test to use BrowserTestUtils.overflowTabs() instead of the test's current implementation.
   • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #fx-desktop-dev channel on Element/Matrix most hours of most days.
4. Build your change with mach build and test your change with mach test browser/base/content/test/tabs/browser_tabReorder_overflow.js --headless. Also check your changes for adherence to our style guidelines by using mach lint.
5. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
   • How to Submit a Patch
   • This is when the bug will be assigned to you.
6. After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland.
   • If there are changes requested, please read the "To update a submitted patch" section to ensure you don't accidentally create a duplicate revision!
   • Your code will soon be shipping to Firefox users worldwide!

Comment 2

[[:samihda]]

Hi Tim, I had a quick look, but I couldn't find the shared overflowTabs function in BrowserTestUtils. Perhaps I'm missing something?

Comment 3

[Tim Giles [:tgiles]]

:samihda, thanks for looking into it! It may have been that searchfox had not updated when you checked it out, as I'm able to see the BrowserTestUtils.overflowTabs function currently. I forget when searchfox indexes new code and all that, but it's pretty quickly.

And for future reference, feel free to use the "Request information from" feature below the comment section. That way I get a direct bugzilla notification instead of just happening to see this when checking my general bugmail :) Let me know if you have any other questions!

Comment 4

[[:samihda]]

Thanks :tgiles, I'll remember that next time :)

Also, I can see the function now. Let me see if I can give this a try soon, perhaps this weekend.

Comment 5

[[:samihda]]

Attachment: Bug 1791439 - Reuse overflowTabs test function. r=tgiles

Comment 6

[[:samihda]]

Attachment: Bug 1791439 - Support prepending/appending new tabs. r=tgiles

Depends on D158090

Comment 7

[[:samihda]]

Attachment: Bug 1791439 - Remove unused event listener. r=tgiles

Depends on D158156

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e30fb8daf0d3
Reuse overflowTabs test function. r=tgiles

Comment 9

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/e30fb8daf0d3