1791532 - Sync vendored puppeteer to v17.1.2

Status: RESOLVED FIXED

(Remote Protocol :: CDP, task, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Version 18.0.3 is the most recent release:
https://github.com/puppeteer/puppeteer/releases/tag/v18.0.3

Very important are the testrunner changes which now include a custom expectation file to more easily set test expectations. This already landed for the 17.1.3 release.

https://github.com/puppeteer/puppeteer/commit/d8830cbc55a07fb0cd7d3ac98d9af4e6d95b179b

That means for us that we probably do no longer have to maintain our own expectation file but could hopefully re-use what's coming from Puppeteer directly.

If that's the case we should also update https://puppeteer.github.io/ispuppeteerfirefoxready/ to use the Puppeteer's own expectation file. I filed the following issue for such a change already:

https://github.com/puppeteer/ispuppeteerfirefoxready/issues/13

Comment 1

[Alexandra Borovova [:Sasha]]

Right now, expectation file from Puppeteer repo doesn't fulfill our requirements since it skips most of the tests which don't pass in Firefox, and we would like to have "fail", "timeout" or "fail, pass" expectations where it's possible. I've opened an issue in Puppeteer repo to see if it's possible to address it in puppeteer repo: https://github.com/puppeteer/puppeteer/issues/9118.

Comment 2

[Alexandra Borovova [:Sasha]]

Attachment: WIP: Bug 1791532 - [puppeteer] Sync puppeteer v19.0.0

Comment 3

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1791532 - [puppeteer] Sync puppeteer v17.1.2

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/69335a15232e
[puppeteer] Sync puppeteer v17.1.2 r=webdriver-reviewers,jdescottes

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/69335a15232e