1791742 - Use the `system_info.cpu_microcode_version` field when available

Status: RESOLVED FIXED

(Socorro :: Processor, task, P2)

Description

[Gabriele Svelto [:gsvelto]]

Our Windows crashes usually contain a CPUMicrocodeVersion annotation that can be useful for detecting crashes coming from machines missing microcode updates. On Linux we don't populate that annotation but we do have the field stored in the minidump, the stack walker surfaces it in the system_info.cpu_microcode_version field. It would be nice to use this as the source of the microcode version instead of the annotation if possible. I filed issues 683 to populate this field in the stackwalker whenever the CPUMicrocodeVersion annotation is present.

Would it be possible to have the processor prefer the value of system_info.cpu_microcode_version if it's available and fall back to CPUMicrocodeVersion if not?

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Currently, it's pulled from the annotation:

https://github.com/mozilla-services/socorro/blob/98ded7173f547ddd0b52d19c00a3a0b46d5f575b/socorro/schemas/processed_crash.schema.yaml#L1057-L1061

We can change that to pull from the stackwalker output and degrade to the annotation if present. We'll need a new rule for that.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 6242: bug 1791742: pull cpu_microcode_version from stackwalker output

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #6242: "bug 1791742: pull cpu_microcode_version from stackwalker output" in 8a885d4.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Oops--turns out that the value the stackwalker emits is a different type.

https://sentry.io/organizations/mozilla/issues/3719279295/?project=6700122

Example: bp-875b8cdf-f0c6-47df-a045-4c9270221104

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 6243: bug 1791742: fix cpu_microcode_version handling to fix values

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #6243: "bug 1791742: fix cpu_microcode_version handling to fix values" in fc4db88.

Comment 9

[Will Kahn-Greene [:willkg] ET needinfo? me]

This was deployed just now in bug #1799933. Marking as FIXED.