Closed Bug 1791786 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 35994 - [scroll-animations] Support view-timeline-inset:auto

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox108 fixed)

Status:
RESOLVED FIXED
Milestone:
108 Branch
Tracking Flags:
Tracking Status
firefox108 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 35994 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/35994
Details from upstream follow.

Anders Hartvoll Ruud <andruud@google.com> wrote:

[scroll-animations] Support view-timeline-inset:auto

When the author specifies view-timeline-inset:auto, it is supposed to
use the value from the corresponding scroll-padding property. This CL
implements that behavior.

Since some utils expect LayoutUnit rather than double, it made sense to
redefine some locals as LayoutUnit to avoid converting too much back and
forth.

Also, it turns out that the default Length() constructor is effectively
"auto", so I had to change the default insets to Length::Fixed(), which
is "0".

Bug: 1317765
Change-Id: I45a07a228df90210db2d4f649071a4b1a482676b
Reviewed-on: https://chromium-review.googlesource.com/3898672
WPT-Export-Revision: f89f26421194b281eca9a67566ada4db14998dc4

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 25 subtests

Status Summary

Firefox

OK : 1
FAIL: 25

Chrome

OK : 1
FAIL: 25

Safari

OK : 1
FAIL: 25

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /scroll-animations/css/view-timeline-inset-animation.html [wpt.fyi]
    • view-timeline-inset with one value: FAIL (Chrome: FAIL, Safari: FAIL)
    • view-timeline-inset with two values: FAIL (Chrome: FAIL, Safari: FAIL)
    • view-timeline-inset with em values: FAIL (Chrome: FAIL, Safari: FAIL)
    • view-timeline-inset with percentage values: FAIL (Chrome: FAIL, Safari: FAIL)
    • view-timeline-inset with negative values: FAIL (Chrome: FAIL, Safari: FAIL)
    • view-timeline-inset with horizontal scroller: FAIL (Chrome: FAIL, Safari: FAIL)
    • view-timeline-inset with block scroller: FAIL (Chrome: FAIL, Safari: FAIL)
    • view-timeline-inset with inline scroller: FAIL (Chrome: FAIL, Safari: FAIL)
    • view-timeline-inset:auto, block: FAIL (Chrome: FAIL, Safari: FAIL)
    • view-timeline-inset:auto, block, vertical-lr: FAIL (Chrome: FAIL, Safari: FAIL)
    • view-timeline-inset:auto, block, vertical-rl: FAIL (Chrome: FAIL, Safari: FAIL)
    • view-timeline-inset:auto, inline: FAIL (Chrome: FAIL, Safari: FAIL)
    • view-timeline-inset:auto, inline, vertical-rl: FAIL (Chrome: FAIL, Safari: FAIL)
    • view-timeline-inset:auto, inline, vertical-lr: FAIL (Chrome: FAIL, Safari: FAIL)
    • view-timeline-inset:auto, inline, rtl: FAIL (Chrome: FAIL, Safari: FAIL)
    • view-timeline-inset:auto, inline, vertical-rl, rtl: FAIL (Chrome: FAIL, Safari: FAIL)
    • view-timeline-inset:auto, inline, vertical-lr, rtl: FAIL (Chrome: FAIL, Safari: FAIL)
    • view-timeline-inset:auto, vertical: FAIL (Chrome: FAIL, Safari: FAIL)
    • view-timeline-inset:auto, vertical, vertical-rl: FAIL (Chrome: FAIL, Safari: FAIL)
    • view-timeline-inset:auto, vertical, vertical-rl, rtl: FAIL (Chrome: FAIL, Safari: FAIL)
    • view-timeline-inset:auto, horizontal: FAIL (Chrome: FAIL, Safari: FAIL)
    • view-timeline-inset:auto, horizontal, rtl: FAIL (Chrome: FAIL, Safari: FAIL)
    • view-timeline-inset:auto, horizontal, vertical-lr: FAIL (Chrome: FAIL, Safari: FAIL)
    • view-timeline-inset:auto, horizontal, vertical-rl: FAIL (Chrome: FAIL, Safari: FAIL)
    • view-timeline-inset:auto, mix: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7768549f07c5 [wpt PR 35994] - [scroll-animations] Support view-timeline-inset:auto, a=testonly https://hg.mozilla.org/integration/autoland/rev/aa91933f937e [wpt PR 35994] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/7768549f07c5
https://hg.mozilla.org/mozilla-central/rev/aa91933f937e

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox108: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in before you can comment on or make changes to this bug.