1791819 - WebDriver:Print does not support the orientation parameter

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect, P1)

Description

[Julian Descottes [:jdescottes]]

See https://github.com/mozilla/geckodriver/issues/2001

The webdriver print command supports an "orientation" parameter, which can either be "landscape" or "portrait", but it seems that marionette expects a "landscape" boolean instead.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Julian is referencing the following code:
https://searchfox.org/mozilla-central/rev/52da19becaa3805e7f64088e91e9dade7dec43c8/remote/shared/PDF.jsm#36

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:whimboo, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Julian Descottes [:jdescottes]]

It would be nice to handle it at the same time as handling print for BiDi.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Setting to P2 given that we most likely want to work on that feature for BiDi in the next milestone.

Comment 5

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1791819 - [marionette] Add support for the orientation parameter in WebDriver:Print.

Comment 6

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1791819 - [wdspec] Add tests for the orientation parameter in WebDriver:Print.

Depends on D173413

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d1b666a9db5
[marionette] Add support for the orientation parameter in WebDriver:Print. r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/ebcf39c1897e
[wdspec] Add tests for the orientation parameter in WebDriver:Print. r=webdriver-reviewers,whimboo

Comment 8

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/39164 for changes under testing/web-platform/tests

Comment 9

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/6d1b666a9db5
https://hg.mozilla.org/mozilla-central/rev/ebcf39c1897e

Comment 10

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot