Open Bug 1791947 Opened 2 years ago Updated 23 days ago

Remove nsIMsgParseMailMsgState.GetAllHeaders() in favor of nsIMsgParseMailMsgState.headers

Categories

(MailNews Core :: Backend, task)

Tracking

(Not tracked)

People

(Reporter: benc, Unassigned)

Details

Remove nsIMsgParseMailMsgState.GetAllHeaders().
The only two uses are in nsImapMailFolder.cpp and nsParseMailbox.cpp.
These should use nsIMsgParseMailMsgState.headers attribute instead.

Reasoning:
.headers provides more-or-less the raw header block of a message.
.GetAllHeaders() provides the same, but with a NUL char replacing the EOL '\r\n'.

Ostensibly, this is because the filter matching requires a NUL-terminated list, but in fact the code that does the matching (nsMsgBodyHandler) handles doing it's own '\r\n' parsing just fine, and actually has to do some considerable hoop-jumping in order to handle NUL-terminated headers!

Summary: Remove nsIMsgParseMailMsgState.GetAllHeaders() → Remove nsIMsgParseMailMsgState.GetAllHeaders() in favor of nsIMsgParseMailMsgState.headers
You need to log in before you can comment on or make changes to this bug.