1791973 - Always retrieve the watcher front via commands.watcherFront

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement)

Description

[Alexandre Poirot [:ochameau]]

While working on bug 1785106, I saw that there was a couple of leftovers still manually fetching the watcher front via descriptorFront.getWatcher().
That, whereas the commands object already does that early and then exposes it to all commands and also via commands.watcherFront.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1791973 - [devtools] Always retrieve the Watcher Front from commands.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d43a5e6878f4
[devtools] Always retrieve the Watcher Front from commands. r=jdescottes

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/d43a5e6878f4

Comment 4

[Julian Descottes [:jdescottes]]

This seems to have slightly regressed complicated.jsdebugger.close. It's not clear why, but the pushlog really points to this single changeset.

== Change summary for alert #36556 (as of Fri, 23 Dec 2022 23:21:36 GMT) ==

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
17%	damp complicated.jsdebugger.close.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender-sw	27.91 -> 32.79
16%	damp complicated.jsdebugger.close.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender	26.13 -> 30.19
13%	damp complicated.jsdebugger.close.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender	28.08 -> 31.67
8%	damp complicated.jsdebugger.close.DAMP	macosx1015-64-shippable-qr	e10s fission stylo webrender	22.55 -> 24.37
7%	damp custom.jsdebugger.close.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender-sw	31.94 -> 34.30

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=36556