1791983 - Form data query parameters truncated

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P2)

Description

[Attila Soki]

Attachment: screenshot console.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:106.0) Gecko/20100101 Firefox/106.0

Steps to reproduce:

executed an XHR POST request in JS with the paramterstring a=bcd::efg/hij=klm,nop&qrs=tuvwxyz.
see the attached testcase-developertools.html
see attached screenshots

Actual results:

all the parameters are submitted correct to the server, but firefox developertools displays only a truncated parameter string, which is misleading.
The value for parameter "a" is displayed as "bcd::efg/hij" and the "=klm,nop" part is not shown.

Expected results:

firefox developertools should display the query parameter as is

Comment 1

[Attila Soki]

Attachment: testcase-developertools.html (testcase file 1 of 2)

Comment 2

[Attila Soki]

Attachment: testcase.php (testcase file 2 of 2)

Comment 3

[Attila Soki]

Attachment: network.png

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:Honza, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thank you for the test case, I can easily reproduce on my machine (Win 10, Fx Nightly)

Online version of the test case
http://janodvarko.cz/tests/bugzilla/1791983/

Honza

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Some info for anyone interested in fixing this bug

1. The request params are rendered here:
   https://searchfox.org/mozilla-central/rev/c5c002f81f08a73e04868e0c2bf0eb113f200b03/devtools/client/netmonitor/src/components/request-details/RequestPanel.js#208

2. The parseFormData seems to be the culprit, it's implemented here:
   https://searchfox.org/mozilla-central/rev/c5c002f81f08a73e04868e0c2bf0eb113f200b03/devtools/client/netmonitor/src/utils/request-utils.js#362

The = sigh in the value is likely breaking the parsing logic

3. Use BrowserToolbox to debug the code (debug DevTools itself)
   https://firefox-source-docs.mozilla.org/devtools-user/browser_toolbox/index.html

4. An automated test will be needed too for this case
   https://firefox-source-docs.mozilla.org/devtools/tests/mochitest-devtools.html

See how existing tests for POST data are written
https://searchfox.org/mozilla-central/search?q=*+Tests+if+the+POST+requests+display+the+correct+information+in+the+UI&path=&case=false&regexp=false

Perhaps extend existing one?

Honza

Comment 7

[Marz Rover [:marzvrover] (they/them)]

I'll try to have a patch submitted tonight :D

Comment 8

[Marz Rover [:marzvrover] (they/them)]

Attachment: Bug 1791983 - split query paramaters at first instance of =, r=Honza,nchevobbe

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 10

[Andrew de Rozario]

Attachment: Bug 1791983 - [devtools] parse complete param value even if containing equals sign r=Honza

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c4d0e1b493c9
[devtools] parse complete param value even if containing equals sign r=devtools-reviewers,ochameau

Comment 12

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/c4d0e1b493c9