1792017 - Multiselect tabs range no longer works when using the Shift key and involving the Firefox View button

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P3)

Description

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Attachment: Screen Recording 2022-09-22 at 15.00.30.mov

Found in

• 106.0b2

Affected versions

• 106.0b2
• 107.0a1

Tested platforms

• Affected platforms: macOS12 ,11/ Windows 10,11 / Ubuntu 22

Steps to reproduce

1. Launch FF .
2. Open multiple tabs.
3. Hold Control/Command button pressed, and starting with FF View button, select multiple tabs.
4. Hold Shift button pressed and select a range between tabs.
5. Go in Firefox View, hold Shift and select another range of tabs.
6. Go back to the tab strip , and select another range of tabs(this time without having FF View in focus or in tab range).

Expected result

• The Shift+Click tabs range selection works without any issues.

Actual result

• The Shift+Click tabs range selection no longer works after performing the steps from STR.

Regression Range

• First bad: 2022-09-16
• Last good: 2022-09-15
• Pushlog
• Potentially regressed by: 1790593

Other notes

• After reproducing these steps, the tab range multi select is no longer functional for the entirety of the session(restart required).
• After performing these steps, the Firefox account becomes corrupted, displaying the "Send 0 tabs to device>" option. Image of the issue
• When performing the required steps to reproduce this issue, the following error is displayed in browser console:

Uncaught TypeError: aTab is undefined
    addToMultiSelectedTabs chrome://browser/content/tabbrowser.js:5042
    addRangeToMultiSelectedTabs chrome://browser/content/tabbrowser.js:5075
    on_mousedown chrome://browser/content/tabbrowser-tab.js:379
    handleEvent chrome://global/content/customElements.js:463

Comment 1

[Ray Fambro]

@Gijs -- Is this expected behavior?

Comment 2

[:Gijs (he/him)]

No, the exception shows this is an error condition. Hopefully Dão can take a look.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1790593

Comment 4

[Pascal Chevrel:pascalc]

Dao, is that something that you will fix in 107/106?

Comment 5

[Ray Fambro]

Hey Pascal. This issue doesn't need to be uplifted in 106, so it's fine to push to a subsequent release.

Comment 6

[Donal Meehan [:dmeehan]]

Setting 107 to wontfix, looks like it's too late for the 107 cycle.
Leaving 108 status clear, unless anyone thinks we should be following this for a fix in 108?

Comment 7

[Sarah Clements [:sclements]]

Dão are you still planning on working on this bug?

Comment 8

[Dão Gottwald [:dao]]

(In reply to Sarah Clements [:sclements] from comment #7)

Dão are you still planning on working on this bug?

Oops, no, sorry.

Comment 9

[Kelly Cochrane [:kcochrane]]

Attachment: Bug 1792017 - Prevent ability to multiselect hidden tabs such as Fx View r=sclements

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c25cea5638c3
Prevent ability to multiselect hidden tabs such as Fx View r=sclements

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c25cea5638c3

Comment 12

[Dana Lucaci, Desktop QA]

Reproduced the issue with Firefox 107.0a1 (2022-09-22) using the steps from the description on macOS 12 and Windows 10.
The issue is verified fixed with Firefox 112.0a1 (20230224092408) and Firefox 111.0b5 (20230223185944) on Windows 10, macOS 12 and Ubuntu 22.