1792043 - Hit MOZ_CRASH(already mutably borrowed) at /third_party/rust/atomic_refcell/src/lib.rs:151

Status: RESOLVED DUPLICATE of bug 1793379

(Core :: Graphics: Text, defect)

Description

[Jason Kratzer [:jkratzer]]

Testcase found while fuzzing mozilla-central rev c9041757a18a (built with: --enable-debug --enable-fuzzing).

Testcase can be reproduced using the following commands:

$ pip install fuzzfetch grizzly-framework
$ python -m fuzzfetch --build c9041757a18a --debug --fuzzing -n firefox
$ python -m grizzly.replay --repeat 10 --relaunch 1 ./firefox/firefox testcase.zip

Hit MOZ_CRASH(already mutably borrowed) at /third_party/rust/atomic_refcell/src/lib.rs:151

    ==71375==ERROR: UndefinedBehaviorSanitizer: SEGV on unknown address 0x000000000000 (pc 0x7fc75d587295 bp 0x7fc74a102f30 sp 0x7fc74a102f20 T71975)
    ==71375==The signal is caused by a WRITE memory access.
    ==71375==Hint: address points to the zero page.
        #0 0x7fc75d587295 in MOZ_Crash /builds/worker/workspace/obj-build/dist/include/mozilla/Assertions.h:261:3
        #1 0x7fc75d587295 in RustMozCrash /mozglue/static/rust/wrappers.cpp:18:3
        #2 0x7fc75d587218 in mozglue_static::panic_hook::ha654bb11f4cf491d /mozglue/static/rust/lib.rs:91:9
        #3 0x7fc75d586c9b in core::ops::function::Fn::call::h5c66be0d65b09404 /rustc/4b91a6ea7258a947e59c6522cd5898e7c0a6a88f/library/core/src/ops/function.rs:77:5
        #4 0x7fc75e531ad9 in std::panicking::rust_panic_with_hook::hb0138cb6e6fea3e4 /rustc/4b91a6ea7258a947e59c6522cd5898e7c0a6a88f/library/std/src/panicking.rs:702:17
        #5 0x7fc75e531916 in std::panicking::begin_panic_handler::_$u7b$$u7b$closure$u7d$$u7d$::h4cb67095557cd1aa /rustc/4b91a6ea7258a947e59c6522cd5898e7c0a6a88f/library/std/src/panicking.rs:588:13
        #6 0x7fc75e52ebe3 in std::sys_common::backtrace::__rust_end_short_backtrace::h2bfcac279dcdc911 /rustc/4b91a6ea7258a947e59c6522cd5898e7c0a6a88f/library/std/src/sys_common/backtrace.rs:138:18
        #7 0x7fc75e531648 in rust_begin_unwind /rustc/4b91a6ea7258a947e59c6522cd5898e7c0a6a88f/library/std/src/panicking.rs:584:5
        #8 0x7fc7539a9332 in core::panicking::panic_fmt::h1de71520faaa17d3 /rustc/4b91a6ea7258a947e59c6522cd5898e7c0a6a88f/library/core/src/panicking.rs:142:14
        #9 0x7fc75def8cbb in core::panicking::panic_display::h7f8ee06a87914a11 /rustc/4b91a6ea7258a947e59c6522cd5898e7c0a6a88f/library/core/src/panicking.rs:72:5
        #10 0x7fc75dfbf906 in atomic_refcell::AtomicRefCell$LT$T$GT$::borrow_mut::hf5cf17dde06214f6 /third_party/rust/atomic_refcell/src/lib.rs:151:23
        #11 0x7fc75dfbf906 in style::shared_lock::SharedRwLock::write::h836772200008494f /servo/components/style/shared_lock.rs:137:32
        #12 0x7fc75de437c8 in geckoservo::glue::write_locked_arc::had69e4996e78bcf0 /servo/ports/geckolib/glue.rs:2097:21
        #13 0x7fc75de437c8 in Servo_FontFaceRule_SetDescriptor /servo/ports/geckolib/glue.rs:3367:5
        #14 0x7fc758fc2b4c in mozilla::dom::FontFaceImpl::SetDescriptor(nsCSSFontDesc, nsTSubstring<char> const&, mozilla::ErrorResult&) /layout/style/FontFaceImpl.cpp:415:8
        #15 0x7fc758fbffd7 in operator() /layout/style/FontFaceImpl.cpp:442:5
        #16 0x7fc758fbffd7 in mozilla::dom::FontFaceImpl::SetDescriptors(nsTSubstring<char> const&, mozilla::dom::FontFaceDescriptors const&) /layout/style/FontFaceImpl.cpp:448:8
        #17 0x7fc758fbfd21 in mozilla::dom::FontFace::Constructor(mozilla::dom::GlobalObject const&, nsTSubstring<char> const&, mozilla::dom::UTF8StringOrArrayBufferOrArrayBufferView const&, mozilla::dom::FontFaceDescriptors const&, mozilla::ErrorResult&) /layout/style/FontFace.cpp:123:20
        #18 0x7fc756c87bcd in mozilla::dom::FontFace_Binding::_constructor(JSContext*, unsigned int, JS::Value*) /builds/worker/workspace/obj-build/dom/bindings/FontFaceBinding.cpp:2128:54
        #19 0x7fc75c563cfc in CallJSNative(JSContext*, bool (*)(JSContext*, unsigned int, JS::Value*), js::CallReason, JS::CallArgs const&) /js/src/vm/Interpreter.cpp:458:13
        #20 0x7fc75c5706e9 in CallJSNativeConstructor(JSContext*, bool (*)(JSContext*, unsigned int, JS::Value*), JS::CallArgs const&) /js/src/vm/Interpreter.cpp:474:8
        #21 0x7fc75c565150 in InternalConstruct(JSContext*, js::AnyConstructArgs const&, js::CallReason) /js/src/vm/Interpreter.cpp:693:10
        #22 0x7fc75c55a8e6 in ConstructFromStack /js/src/vm/Interpreter.cpp:721:10
        #23 0x7fc75c55a8e6 in Interpret(JSContext*, js::RunState&) /js/src/vm/Interpreter.cpp:3359:16
        #24 0x7fc75c5519fd in js::RunScript(JSContext*, js::RunState&) /js/src/vm/Interpreter.cpp:430:13
        #25 0x7fc75c56351d in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) /js/src/vm/Interpreter.cpp:578:13
        #26 0x7fc75c564a5c in js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason) /js/src/vm/Interpreter.cpp:645:8
        #27 0x7fc75b1e391c in JS::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::HandleValueArray const&, JS::MutableHandle<JS::Value>) /js/src/vm/CallAndConstruct.cpp:117:10
        #28 0x7fc756bbc423 in mozilla::dom::EventHandlerNonNull::Call(mozilla::dom::BindingCallContext&, JS::Handle<JS::Value>, mozilla::dom::Event&, JS::MutableHandle<JS::Value>, mozilla::ErrorResult&) /builds/worker/workspace/obj-build/dom/bindings/EventHandlerBinding.cpp:299:37
        #29 0x7fc75748c529 in void mozilla::dom::EventHandlerNonNull::Call<nsCOMPtr<mozilla::dom::EventTarget> >(nsCOMPtr<mozilla::dom::EventTarget> const&, mozilla::dom::Event&, JS::MutableHandle<JS::Value>, mozilla::ErrorResult&, char const*, mozilla::dom::CallbackObject::ExceptionHandling, JS::Realm*) /builds/worker/workspace/obj-build/dist/include/mozilla/dom/EventHandlerBinding.h:367:12
        #30 0x7fc75748b703 in mozilla::JSEventHandler::HandleEvent(mozilla::dom::Event*) /dom/events/JSEventHandler.cpp:201:12
        #31 0x7fc75746c86e in mozilla::EventListenerManager::HandleEventSubType(mozilla::EventListenerManager::Listener*, mozilla::dom::Event*, mozilla::dom::EventTarget*) /dom/events/EventListenerManager.cpp:1316:22
        #32 0x7fc75746d4d7 in mozilla::EventListenerManager::HandleEventInternal(nsPresContext*, mozilla::WidgetEvent*, mozilla::dom::Event**, mozilla::dom::EventTarget*, nsEventStatus*, bool) /dom/events/EventListenerManager.cpp:1506:17
        #33 0x7fc757462414 in HandleEvent /dom/events/EventListenerManager.h:395:5
        #34 0x7fc757462414 in mozilla::EventTargetChainItem::HandleEvent(mozilla::EventChainPostVisitor&, mozilla::ELMCreationDetector&) /dom/events/EventDispatcher.cpp:348:17
        #35 0x7fc757461962 in mozilla::EventTargetChainItem::HandleEventTargetChain(nsTArray<mozilla::EventTargetChainItem>&, mozilla::EventChainPostVisitor&, mozilla::EventDispatchingCallback*, mozilla::ELMCreationDetector&) /dom/events/EventDispatcher.cpp:550:16
        #36 0x7fc757464201 in mozilla::EventDispatcher::Dispatch(nsISupports*, nsPresContext*, mozilla::WidgetEvent*, mozilla::dom::Event*, nsEventStatus*, mozilla::EventDispatchingCallback*, nsTArray<mozilla::dom::EventTarget*>*) /dom/events/EventDispatcher.cpp:1119:11
        #37 0x7fc757466c76 in mozilla::EventDispatcher::DispatchDOMEvent(nsISupports*, mozilla::WidgetEvent*, mozilla::dom::Event*, nsPresContext*, nsEventStatus*) /dom/events/EventDispatcher.cpp
        #38 0x7fc75743bbbb in mozilla::DOMEventTargetHelper::DispatchEvent(mozilla::dom::Event&, mozilla::dom::CallerType, mozilla::ErrorResult&) /dom/events/DOMEventTargetHelper.cpp:176:17
        #39 0x7fc757473ee2 in mozilla::dom::EventTarget::DispatchEvent(mozilla::dom::Event&) /dom/events/EventTarget.cpp:180:13
        #40 0x7fc758800681 in mozilla::dom::MessageEventRunnable::DispatchDOMEvent(JSContext*, mozilla::dom::WorkerPrivate*, mozilla::DOMEventTargetHelper*, bool) /dom/workers/MessageEventRunnable.cpp:104:12
        #41 0x7fc758842fee in mozilla::dom::WorkerRunnable::Run() /dom/workers/WorkerRunnable.cpp:377:12
        #42 0x7fc753d5dde7 in nsThread::ProcessNextEvent(bool, bool*) /xpcom/threads/nsThread.cpp:1199:16
        #43 0x7fc753d6432d in NS_ProcessNextEvent(nsIThread*, bool) /xpcom/threads/nsThreadUtils.cpp:465:10
        #44 0x7fc758831d54 in mozilla::dom::WorkerPrivate::DoRunLoop(JSContext*) /dom/workers/WorkerPrivate.cpp:3204:7
        #45 0x7fc75881ae1b in mozilla::dom::workerinternals::(anonymous namespace)::WorkerThreadPrimaryRunnable::Run() /dom/workers/RuntimeService.cpp:2042:42
        #46 0x7fc753d5dde7 in nsThread::ProcessNextEvent(bool, bool*) /xpcom/threads/nsThread.cpp:1199:16
        #47 0x7fc753d6432d in NS_ProcessNextEvent(nsIThread*, bool) /xpcom/threads/nsThreadUtils.cpp:465:10
        #48 0x7fc7549458db in mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) /ipc/glue/MessagePump.cpp:300:20
        #49 0x7fc754869d77 in MessageLoop::RunInternal() /ipc/chromium/src/base/message_loop.cc:381:10
        #50 0x7fc754869c82 in RunHandler /ipc/chromium/src/base/message_loop.cc:374:3
        #51 0x7fc754869c82 in MessageLoop::Run() /ipc/chromium/src/base/message_loop.cc:356:3
        #52 0x7fc753d59116 in nsThread::ThreadFunc(void*) /xpcom/threads/nsThread.cpp:384:10
        #53 0x7fc76a698557 in _pt_root /nsprpub/pr/src/pthreads/ptthread.c:201:5
        #54 0x7fc76af46b42 in start_thread nptl/./nptl/pthread_create.c:442:8
        #55 0x7fc76afd89ff  misc/../sysdeps/unix/sysv/linux/x86_64/clone3.S:81
    
    UndefinedBehaviorSanitizer can not provide additional info.
    SUMMARY: UndefinedBehaviorSanitizer: SEGV /builds/worker/workspace/obj-build/dist/include/mozilla/Assertions.h:261:3 in MOZ_Crash
    ==71375==ABORTING

Comment 1

[Jason Kratzer [:jkratzer]]

Attachment: Testcase

Comment 2

[Bugmon [:jkratzer for issues]]

Bugmon Analysis
Verified bug as reproducible on mozilla-central 20220922095647-c9041757a18a.
The bug appears to have been introduced in the following build range:

Start: 14bbdad41ca8f9cbe874b8e1adf10a701ff81517 (20220711154729)
End: 0fa881dedc30efcf53f1419737a9f3d7d2fc5521 (20220711143742)
Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=14bbdad41ca8f9cbe874b8e1adf10a701ff81517&tochange=0fa881dedc30efcf53f1419737a9f3d7d2fc5521

Comment 3

[Sotaro Ikeda [:sotaro]]

:aosmond, can you comment to the bug? It seemed similar to Bug 1791874.

Comment 4

[Tyson Smith [:tsmith]]

Marking as fuzzblocker because this is hit frequently by fuzzers and is impacting our ability to fuzz Font Loading related code.

Comment 5

[Tyson Smith [:tsmith]]

A Pernosco session is available here: https://pernos.co/debug/ITtmUlnrTlATuVRPvCThFw/index.html

Comment 6

[BugBot [:suhaib / :marco]]

This bug prevents fuzzing from making progress; however, it has low severity. It is important for fuzz blocker bugs to be addressed in a timely manner (see here why?).
:lsalzman, could you increase the severity?

For more information, please visit auto_nag documentation.

Comment 7

[Kelsey Gilbert [:jgilbert]]

Let's try to include reasoning if we're going to mark fuzzblockers as less than S2.

@jfkthame: Is this fuzzblocker actionable for you?
It might unblock more/better repro cases for other font issues if we can fix it.

Comment 8

[Andrew Osmond [:aosmond] (he/him)]

I'm not sure if this needs to be made a sec bug honestly, but the bug where I am fixing this is so....

Comment 9

[Bugmon [:jkratzer for issues]]

No valid actions for resolution (DUPLICATE).
Removing bugmon keyword as no further action possible. Please review the bug and re-add the keyword for further analysis.