1792157 - Wrong visibility for bundled fonts with font-list.shared true on Linux

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect, P3)

Description

[Pier Angelo Vendrame]

Bug 1745715 regresses when gfx.e10s.font-list.shared is set to true.

So, if a font is available both as system font and as bundled font, its visibility is wrong and it is not rendered on Ubuntu and Fedora.
When I flip gfx.e10s.font-list.shared back to false, everything works as expected again.

Steps to reproduce:

1. Install a system font that isn't normally installed in Ubuntu/Fedora
2. Copy the same font to the fonts directory
3. Enable RFP on your profile and make sure gfx.e10s.font-list.shared is true
4. Go to any website, and set the font you chose as a font-family with the inspector: it will be rendered as the default font-family (e.g., serif)
5. Set gfx.e10s.font-list.shared to false and restart Firefox
6. Repeat 4 again: this time the font will be rendered (which is the expected behavior)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:alaskanemily, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1745715

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1745715

Comment 4

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1792157 - Ensure correct font-visibility for bundled fonts on Linux when they 'shadow' system-installed families.

Comment 5

[Jonathan Kew [:jfkthame]]

I think this should simply be a question of initialization order.

@pierov, could you try the attached patch and confirm whether it fixes the behavior for you? Thanks! If so, I'll tag it for review.

Comment 6

[Jonathan Kew [:jfkthame]]

OK, I tested this on my Ubuntu machine and confirmed that it makes the font visible, as expected. (Additional testing welcome, but I'm going to go ahead and ask for review here so we can land the patch.)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d43ce763a307
Ensure correct font-visibility for bundled fonts on Linux when they 'shadow' system-installed families. r=gfx-reviewers,lsalzman

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/d43ce763a307

Comment 9

[Pier Angelo Vendrame]

Yes, I confirm it works, thank you!
(sorry for the delay)

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jfkthame, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox113 to wontfix.

For more information, please visit auto_nag documentation.