1792162 - Add right handside padding to "Add Custom Device" form in RDM's device dialog

Status: RESOLVED FIXED

(DevTools :: Responsive Design Mode, enhancement, P3)

Description

[Julian Descottes [:jdescottes]]

Attachment: image.png

Minor CSS issue, good first bug for anyone who wants to setup their dev environment.

Steps to reproduce:

• open Responsive Design Mode on any website (Browser Tools > Responsive Design Mode)
• open the preset selector and select "Edit List..."
• (this should open a modal dialog)
• click the "Add Custom Device" button on the top right

This will add a form in the dialog, and there clearly should be some padding at the right of the "Device Pixel Ratio" input. At least for symmetry.

To fix this we can just update https://searchfox.org/mozilla-central/rev/a26af613a476fafe6c3eba05a81bef63dff3c9f1/devtools/client/responsive/index.css#593

from

 padding: 15px 0 10px 20px;

to

 padding: 15px 20px 10px 20px;

Comment 1

[eric]

Hello, I'm learning how to code and how to contribute to open source projects. May I be assigned to this?

Comment 2

[Julian Descottes [:jdescottes]]

Hi eric!

Sure thing, assigning the bug to you. Please take a look at the contributor documentation at https://firefox-source-docs.mozilla.org/setup/index.html if you haven't already, and if you have any question, you can ask here (please use the "request information from" field to ping me explicitly) or join our chat at https://chat.mozilla.org/#/room/#devtools:mozilla.org

Thanks for helping out!

Comment 3

[eric]

Attachment: Bug 1792162 - Fixed minor device form CSS issue.

Comment 4

[Julian Descottes [:jdescottes]]

Hi eric, the attached patch looks good to me. Do you want to move it to review so that we can get this landed?

Comment 5

[eric]

Yes, is that something I have to do?

Comment 6

[Julian Descottes [:jdescottes]]

The current patch is marked as a "work in progress" (WIP) and can't be reviewed. Maybe you pushed it to phabricator with a flag that forces it to remain in WIP status (maybe you used --wip ?).

Comment 7

[eric]

I did a -moz-phab -no-whip, but it said that the revision hasn't changed and will not be submitted. I'm hoping it worked anyway lol

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 9

[JACKSONWHALE]

Hi,
I haven't seen any action on this thread. I've read through the firefox source docs on how to contribute and would like to take on this bug. My understanding is I just need to make the necessary change, submit it to phabricator for review, then after review commit the change?

Comment 10

[Nicolas Chevobbe [:nchevobbe]]

(In reply to JACKSONWHALE from comment #9)

Hi,
I haven't seen any action on this thread. I've read through the firefox source docs on how to contribute and would like to take on this bug. My understanding is I just need to make the necessary change, submit it to phabricator for review, then after review commit the change?

Almost :) You can make the change and commit, then push to phabricator using moz-phab, someone will review it and when it's all good we'll land it. I'm assigning the bug to you

Comment 11

[Julian Descottes [:jdescottes]]

I see I missed the patch from :eric here, sorry about that.

Comment 12

[JACKSONWHALE]

Attachment: Bug 1792162 - Fixed #device-form right side padding in index.css. r?#devtools-reviewers

Comment 13

[JACKSONWHALE]

(In reply to Julian Descottes [:jdescottes] from comment #11)
(In reply to Nicolas Chevobbe [:nchevobbe] from comment #10)

Thank you both for your help. I've attatched my bug above I was unsure who to assign as the reviewer when committing, I hope the dev-tools group is ok. Please let me know if there's anything else I need to do.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2288a4992fac
Fixed #device-form right side padding in index.css. r=devtools-reviewers,jdescottes

Comment 15

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/2288a4992fac