1792172 - [wpt-sync] Sync PR 36046 - compute pressure: Remove promise with observe method

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 36046 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36046
Details from upstream follow.

Arnaud Mandy <[e-mail]> wrote:

compute pressure: Remove promise with observe method

The specifications has never used promises for observe method [1]

compute_pressure_disconnect wpt tests are also re-enabled.

Fenced frame testing introduced in [2] is re-implemented as a
content/browser unit test.

[1] https://github.com/WICG/compute-pressure/commit/c74a21b66db316a1249f251378bcd2296d5e2f3e
[2] https://chromium-review.googlesource.com/c/chromium/src/+/3820425

Bug: 1308303
Change-Id: Iac35115e10c7daa67c84c2bc637c97082bbf77be
Reviewed-on: https://chromium-review.googlesource.com/3867324
WPT-Export-Revision: f04787bab2ca23153a65dc7a0be7bf0028baf18a

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 36046 applied with additional changes from upstream: 897ce2dd1814c5c7a38acbfc8ddad221e77363ed, 00f3dc140f7da496ea0027f36eec0733fa3f9b2c, 694f4357aca90e45168dab088ea4e0a393eddff8, 55d9b917356ecf3e5fdfdc60ef06d4dbdfcfed3e, 0910eb6813dc7e4f658ed0c24bbc6b9c14000cbd, b140d36c82f67d69d107918ff28994d6dbbd55f1, ebbf1e7c530c4a1fc26a9d083554807150acbfdb

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=43d80f6491142159fe4ea96cbead5e7b3fb093d3

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 12 tests and 2 subtests

Status Summary

Firefox

OK : 12
PASS : 1
FAIL : 17

Chrome

OK : 11
PASS : 6
FAIL : 12
ERROR: 1

Safari

OK : 12
PASS : 1
FAIL : 17

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /compute-pressure/compute_pressure_basic.tentative.https.window.html [wpt.fyi]
  • An active PressureObserver calls its callback at least once: FAIL (Chrome: PASS, Safari: FAIL)
• /compute-pressure/compute_pressure_basic_async.tentative.https.window.html [wpt.fyi]
  • Basic functionality test: FAIL (Chrome: FAIL, Safari: FAIL)
  • Removing observer before observe() resolves works: FAIL (Chrome: FAIL, Safari: FAIL)
• /compute-pressure/compute_pressure_detached_iframe.tentative.https.html [wpt.fyi]
  • PressureObserver.observe() on detached frame throws error.: FAIL (Chrome: FAIL, Safari: FAIL)
  • PressureObserver.disconnect() on detached frame returns: FAIL (Chrome: PASS, Safari: FAIL)
  • PressureObserver on detached frame returns with no callback: FAIL (Chrome: PASS, Safari: FAIL)
• /compute-pressure/compute_pressure_disconnect.tentative.https.window.html [wpt.fyi]
  • Stopped PressureObserver do not receive changes: FAIL (Chrome: FAIL, Safari: FAIL)
• /compute-pressure/compute_pressure_disconnect_idempotent.tentative.https.window.html [wpt.fyi]
  • Stopped PressureObserver do not receive changes: FAIL (Chrome: FAIL, Safari: FAIL)
• /compute-pressure/compute_pressure_disconnect_immediately.tentative.https.window.html [wpt.fyi]
  • Stopped PressureObserver do not receive changes: FAIL (Chrome: FAIL, Safari: FAIL)
• /compute-pressure/compute_pressure_duplicate_updates.tentative.https.window.html [wpt.fyi]
  • Changes that fail the "has change in data" test are discarded.: FAIL (Chrome: FAIL, Safari: FAIL)
• /compute-pressure/compute_pressure_multiple.tentative.https.window.html [wpt.fyi]
  • Three PressureObserver instances receive changes: FAIL (Chrome: FAIL, Safari: FAIL)
• /compute-pressure/compute_pressure_multiple_across_iframes.tentative.https.window.html [wpt.fyi]
  • Three PressureObserver instances, in different iframes, receive changes: FAIL (Chrome: FAIL, Safari: FAIL)
• /compute-pressure/compute_pressure_observe_idempotent.tentative.https.window.html [wpt.fyi]
  • PressureObserver.observe() is idempotent: FAIL (Chrome: FAIL, Safari: FAIL)
• /compute-pressure/compute_pressure_observe_unobserve_failure.tentative.https.window.html [wpt.fyi]
  • PressureObserver.observe() requires a valid source: FAIL (Chrome: FAIL, Safari: FAIL)
  • PressureObserver.unobserve() requires a valid source: FAIL (Chrome: PASS, Safari: FAIL)
• /compute-pressure/compute_pressure_take_records.tentative.https.window.html [wpt.fyi]
  • Calling takeRecords() before observe(): FAIL (Chrome: PASS, Safari: FAIL)
  • takeRecords() returns empty record after callback invoke: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f5900c1ea77
[wpt PR 36046] - compute pressure: Remove promise with observe method, a=testonly
https://hg.mozilla.org/integration/autoland/rev/3f8f762bf92a
[wpt PR 36046] - Update wpt metadata, a=testonly

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/2f5900c1ea77
https://hg.mozilla.org/mozilla-central/rev/3f8f762bf92a