1792199 - Quick Actions: Move Help/Question Mark icon 10px to the right to be aligned with Settings icon

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Mehmet]

Attachment: actual.png

Nightly 107.0a1 (2022-09-23) (64-Bit)
macOS

1.) Focus the Address Bar
2.) Take a look at the position of the Move Help/Question Mark icon in the Quick Actions section.
3.) Compare with the position of the Settings icon or the Bookmarks icon

Actual: The Help/Question Mark icon is 10px too far left.

Expected: The Help/Question Mark icon should be moved 10px to the right to be aligned with the Settings icon and the Bookmarks icon.

BTW: It is correct aligned, when the window shrinked to a smaller size.

Thanks.

Comment 1

[Mehmet]

Attachment: expected.png

• Expected screenshot.

Comment 2

[Mehmet]

Attachment: correct aligned in smaller window.png

• screenshot: correct aligned in smaller window

Comment 3

[Daisuke Akatsuka (:daisuke)]

Attachment: Screen Shot 2022-09-27 at 12.17.50.png

I took a look at this issue
As we can see from the attachment, when we select the button by the keyboard, a thick outline will be shown. In considering the outline, it seems that it might be hard to adjust the x position to match the setting button perfectly. The setting button is located on the right edge. Here, if we adjust the help button as well to match the setting button, the right side of the outline will be hidden.
The content area of the main container of the result view is defined here, and if we change it, it might be possible. However, it affects all contents in the result view, we might better not change now.
But, the current position is lefty a bit even if we consider the outline, I will adjust as much as we can.
Thanks!

Comment 4

[Daisuke Akatsuka (:daisuke)]

Attachment: Screen Shot 2022-09-27 at 12.20.11.png

And also, if we shorten the window size, the right side of the outline will be hidden.
I will fix it as well in this bug.

Comment 5

[Mehmet]

Thanks for fixing :) Ah, I didn't know that the Help button has an outline. Is this intentional? If not, maybe it could be removed? Because the main Quick action buttons don't have this outline. Thanks.

Comment 6

[Mehmet]

(In reply to Mehmet from comment #5)

Thanks for fixing :) Ah, I didn't know that the Help button has an outline. Is this intentional? If not, maybe it could be removed? Because the main Quick action buttons don't have this outline. Thanks.

I mean instead of the outline to set a hover button then :)

Comment 7

[Daisuke Akatsuka (:daisuke)]

Attachment: Screen Shot 2022-09-27 at 15.08.07.png

Yeah, that is one of the ideas.
However, the same style help button may be shown for other suggestions.
To keep the consistency with it, we need to keep this style.

Another suggestion would be to change the style of all help buttons to not use outline, as you said.
Dale, what do you think?

(Anyway, I will proceed to fix it by assuming the outline for now.)

Comment 8

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1792199: Adjust x position for help button to fit with Settings button as much as we can.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f79b34387d8
Adjust x position for help button to fit with Settings button as much as we can. r=daleharvey

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/1f79b34387d8

Comment 11

[Petruta Horea [:phorea], Desktop QA]

Verified using Firefox 107 beta 3 under Win 10 64-bit, Ubuntu 22.04 and Mac OSX 10.14 that the Help button is now shifted a few pixels to the right.

Comment 12

[Dale Harvey (:daleharvey)]

clearing as we resolved this / landed it