1792204 - Quick Actions: Button size should be calculated to use the same width when shrinking the window

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Mehmet]

Attachment: actual.png

107.0a1 (2022-09-23) (64-Bit)
macOS

1.) Focus the Address Bar
2.) Make the window smaller
3.) Take a look at the dynamic sizes of the Quick Action Buttons

Actual: The sizes look different. Icons in the buttons are not centered and some have still a snippet of text.

Expected: They should have all the same size. Especially when the window is very small, then the icon in the button should be centered.

Thanks.

Comment 1

[Mehmet]

Attachment: expected.png

• expected screenshot

Comment 2

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1792204: Keeps icon width when shrinking the window.

Depends on D158219

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:adw, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1792204: Add a forgotten semicolon.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/661743d2883a
Keeps icon width when shrinking the window. r=daleharvey
https://hg.mozilla.org/integration/autoland/rev/6587b0e3a09e
Add a forgotten semicolon. r=desktop-theme-reviewers,Itiel

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/661743d2883a
https://hg.mozilla.org/mozilla-central/rev/6587b0e3a09e

Comment 7

[Mehmet]

Thanks for fixing this issue. I noticed a small edge case and reported Bug 1795293. Thanks for checking.

Comment 8

[Petruta Horea [:phorea], Desktop Test Engineering]

Verified as fixed using Firefox 107 beta 3 under Win 10 64-bit, Ubuntu 22.04 and Mac OSX 10.14.