1792230 - Make it possible to import bookmarks data from the DuckDuckGo browser

Status: NEW

(Firefox :: Migration, enhancement)

Description

[Mike Conley (:mconley) (:⚙️)]

Steps to reproduce:

I tried to import data from another browser.

Actual results:

DuckDuckGo isn't listed.

Expected results:

DuckDuckGo should be listed.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

What we'd like you to do Brian is to install a copy of the DuckDuckGo browser and study it a bit. Is it based on Chromium? Or (as I think I've heard recently) does it use the OS's built-in web engine?

Comment 2

[Mike Conley (:mconley) (:⚙️)]

This browser has just launched in the Apple App Store: https://apps.apple.com/gb/app/duckduckgo-private-browser/

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Alvin's notes: https://docs.google.com/document/d/1m9aP4UohphFuzi6oSGTcFNziNSqX6txqjjbXwsyiXbI/edit?usp=sharing

Great research, Alvin! Here's how we can get started on this:

1. Create a new file called browser/components/migration/DuckDuckGoProfileMigrator.sys.mjs, and then hg add it to tracking.

2. Put this boilerplate in the file (see attachment)

3. Then add the migrator to MigrationUtils here, above EdgeProfileMigrator: https://searchfox.org/mozilla-central/rev/7939a5150dcd96915bccf1c819433ad489a5edc9/browser/components/migration/MigrationUtils.sys.mjs#37. Remember, it should only be available for the macosx platform.

4. Add the DuckDuckGo string to migrationWizard.ftl - something like:

migration-wizard-migrator-display-name-duckduckgo = DuckDuckGo

above here: https://searchfox.org/mozilla-central/rev/7939a5150dcd96915bccf1c819433ad489a5edc9/browser/locales/en-US/browser/migrationWizard.ftl#38

Then, if you do ./mach build faster, I think you should see DuckDuckGo show up in the list of things that can be migrated from in the new migration wizard.

That'll get you started - the real work will be to access the SQLite database inside of that GetBookmarksResource function, and read the bookmarks out. Then we'll need to construct the right structure for calling MigrationUtils.insertManyBookmarksWrapper.

5. Finally, enable the migrator by default by adding pref("browser.migrate.duckduckgo.enabled", true); in this list: https://searchfox.org/mozilla-central/rev/7939a5150dcd96915bccf1c819433ad489a5edc9/browser/app/profile/firefox.js#2160

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Boilerplate

I haven't tested this, but from inspection, I think it should work.

Comment 5

[Alvin]

Attachment: Bug 1792230 - Make it possible to import bookmarks data from the DuckDuckGo browser. r?mconley

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Ah, one thing I forgot to include in the instructions - we need to package the .mjs file so that it can be imported.

Please add DuckDuckGoProfileMigrator.sys.mjs to this list here: https://searchfox.org/mozilla-central/rev/53631b0cfb807325b85394a340cc1c5a8dc2de4f/browser/components/migration/moz.build#68

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.