1792255 - add telemetry_environment to processed crash

Status: RESOLVED FIXED

(Socorro :: Processor, defect, P2)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

We should add telemetry_environment to the processed crash. When doing this, we can add a source_annotation so that the CopyFromRawCrashRule handles validation and copying it over.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

I added telemetry environment data to the processed crash schema and cribbed from the telemetry event schema:

https://github.com/mozilla-services/mozilla-pipeline-schemas/blob/d7c892dbfe46c37c44d897b8edb8b0d9f5273fec/schemas/telemetry/event/event.4.schema.json

A lot of fields have no descriptions. It'd be nice to have descriptions for everything.

I omitted the "attribution" section. That's covered in bug #1803147.

I changed the report view to show the telemetry environment data from the processed crash and degrade to using the TelemetryEnvironment annotation from the raw crash.

While working on this, I improved the validate_processed_crash.py script. It's a little clearer about what it's telling you and what you should do about it. I also fixed a couple of places to be clearer about the crux of the problem so it's easier to track down schema issues.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 6264: bug 1792255: add telemetry_environment to processed crash schema

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #6264: "bug 1792255: add telemetry_environment to processed crash schema" in a660fc9.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Re-fixing match_key so it's less ugly is covered in bug #1803189.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

I pushed this just now to production in bug #1803661.