1792263 - Fix prefers-contrast media queries in aboutwelcome.scss

Status: RESOLVED FIXED

(Firefox :: Messaging System, defect, P2)

Description

[Shane Hughes [:aminomancer]]

Firefox generally uses @media (prefers-contrast) for HCM related styles, but we have some rules in aboutwelcome.scss that read @media (prefers-contrast: more). I'm not sure how often this matters, but at least in theory, the HCM styles from common/common-shared.css will be applying to the surfaces that load aboutwelcome.css when prefers-contrast: less or prefers-contrast: custom.

Also, in bug 1790396 Emily added @media (prefers-contrast) rules to _feature-callout.scss, since the rules on Firefox View use that query. So to make sure all these rules are applying under exactly the same conditions, we should use the same query in all cases (unless we end up adding rules for very specific contrast themes, but there don't seem to be any instances of that in the Firefox code, not counting test cases)

Comment 1

[Shane Hughes [:aminomancer]]

I suspect one possible area where this matters may be in forced colors mode, but I haven't done any testing yet.

Comment 2

[Shane Hughes [:aminomancer]]

Attachment: Bug 1792263 - Consolidate prefers-contrast queries in aboutwelcome. r=pdahiya!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a617f6906f0
Consolidate prefers-contrast queries in aboutwelcome. r=pdahiya

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:tspurway, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/1a617f6906f0