1792276 - In Library, "Show in Folder" leaves the focused bookmark outside the visible area

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect, P3)

Description

[tgn-ff]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:107.0) Gecko/20100101 Firefox/107.0

Steps to reproduce:

1. Use the search field of the Library window to search for a bookmark which is inside a folder with enough bookmarks that scrolling is needed to see them all.
2. Right-click on it and select "Show in Folder".

Actual results:

At step 2, the Library focuses on the containing folder and the bookmark is selected, but you have to scroll down to see it.

Expected results:

This is a regression from Bug 1786518.

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2f9e4f4b41314d9d9d12ee4588087f766f29259b&tochange=31865a7b9f1bcb9211eb2d47fd88f7b168aedca8

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:jteow, since you are the author of the regressor, bug 1786518, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 2

[Rares Doghi, Desktop QA]

This issue only occurs in our latest Nightly builds, Beta 106.0b9 and Release do not have this issue.

Comment 3

[Marco Bonardo [:mak]]

This was briefly addressed, but we had to backout the patch in bug 1786518, because it was causing too many edge problems. So in practice this never worked if not for a few versions. It's technically a regression, but not really recent or high priority.

I think we could add a third argument to selectItems() to "ensureItemIsVisible" and then use that in PlacesController.showInFolder().

Comment 4

[James Teow [:jteow]]

Woops, sorry for not setting the priority/severity Marco, thank for you for triaging this bug for me.

Comment 5

[Dão Gottwald [:dao]]

We can't reproduce this anymore, it seems to have been fixed somehow.