Closed
Bug 179228
Opened 22 years ago
Closed 22 years ago
static nsCOMPtr in nsTextControlFrame
Categories
(Core :: Layout: Form Controls, defect, P3)
Core
Layout: Form Controls
Tracking
()
RESOLVED
FIXED
mozilla1.3alpha
People
(Reporter: dbaron, Assigned: dbaron)
References
Details
(Whiteboard: [patch])
Attachments
(1 file)
|
4.12 KB,
patch
|
john
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
See bug 60697 for an explanation. nsTextControlFrame.cpp has used a static
nsCOMPtr (in the guise of nsWeakPtr) for ages, and I've had this fix in my tree,
in various forms, for years.
|
Assignee | |
Updated•22 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P3
Summary: static nsCOMPtr in → static nsCOMPtr in nsTextControlFrame
Whiteboard: [patch]
Target Milestone: --- → mozilla1.3alpha
|
|
Assignee | |
Comment 1•22 years ago
|
||
|
|
Assignee | |
Updated•22 years ago
|
Attachment #105687 -
Flags: superreview?(bzbarsky)
Attachment #105687 -
Flags: review?(jkeiser)
|
||
Updated•22 years ago
|
Attachment #105687 -
Flags: superreview?(bzbarsky) → superreview+
|
||
Updated•22 years ago
|
Attachment #105687 -
Flags: review?(jkeiser) → review+
|
|
Assignee | |
Comment 2•22 years ago
|
||
Fix checked in to trunk, 2002-07-19 07:21 PDT.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 3•22 years ago
|
||
I had to land Makefile changes (INCLUDES and REQUIRES) too, afterwards...
For the record, this reduced codesize slightly. From Garrett's codesize test:
libgklayout.so
Total: -112 (+72/-184)
Code: -112 (+72/-184)
Data: +0 (+0/+0)
-112 (+72/-184) T (CODE)
-112 (+72/-184) UNDEF:libgklayout.so:T
+64 nsTextControlFrame::ReleaseGlobals(...
+8 Shutdown(nsIModule *)
-4 atexit
-44 __tcf_0
-136 GetElementFactoryService(nsIElement...
You need to log in
before you can comment on or make changes to this bug.
Description
•